[SYCL] Fix missing dependency on UR headers #16261
Conversation
|
As discussed in this unrelated patch, changing the UR headers is not properly reflected in the build graph. |
sycl/CMakeLists.txt
Outdated
| @@ -243,6 +243,11 @@ add_custom_target(sycl-headers | |||
| sycl-device-aspect-macros-header | |||
| boost_mp11-headers) | |||
|
|
|||
| list(APPEND UR_HEADERS | |||
There was a problem hiding this comment.
It looks like UR_HEADERS is originally defined in UR itself here and these three files are UR files, should the fix instead be in UR itself rather than SYCL? This is fine as a temporary fix though
There was a problem hiding this comment.
The fix is really not to copy headers to sycl's build directory in the first place, but use target_include_directories(PRIVATE. The whole way we do dependencies isn't proper cmake, and I need to flense the whole thing. This is temporary
There was a problem hiding this comment.
I could change that variable name, though. Didn't realise it clashed
There was a problem hiding this comment.
i dont know enough about cmake anyway, i thought it was intentionally clashing :P
There was a problem hiding this comment.
Updated to use the delightfully quaint "UR_HEADERS_TO_COPY"
No description provided.