[SYCL] Fix multi-device support for persistent cache #16056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
force-pushed
the
persistent_multi_device
branch
2 times, most recently
from
36699f1 to
721af83
Compare
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
force-pushed
the
persistent_multi_device
branch
from
721af83 to
dae4c02
Compare
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
force-pushed
the
persistent_multi_device
branch
from
dae4c02 to
a55bf0a
Compare
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| @@ -116,7 +116,7 @@ if(SYCL_UR_USE_FETCH_CONTENT) | |||
| CACHE PATH "Path to external '${name}' adapter source dir" FORCE) | |||
| endfunction() | |||
|
|
|||
| set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git") | |||
| set(UNIFIED_RUNTIME_REPO "https://github.com//againull/unified-runtime") | |||
There was a problem hiding this comment.
don't you need to set the UNIFIED_RUNTIME_TAG as well?
There was a problem hiding this comment.
Yes, it is set in a separate file sycl/cmake/modules/UnifiedRuntimeTag.cmake now: https://github.com/intel/llvm/pull/16056/files#diff-0c7fff539c30bbbd3e5b33eb55120e2035bead3f75119e145b167ac1a9cf8c5f
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
force-pushed
the
persistent_multi_device
branch
from
4bd2b2a to
fbba36d
Compare
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
force-pushed
the
persistent_multi_device
branch
2 times, most recently
from
c2fbec1 to
782a184
Compare
againull
force-pushed
the
persistent_multi_device
branch
from
782a184 to
595c566
Compare
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
pbalcer
reviewed
Nov 14, 2024
| # Currently urProgramGetInfo will return UR_INVALID_PROGRAM is program is | ||
| # compiled only for a subset of associated devices, i.e. not all devices | ||
| # have level zero module and binaries. This PR fixes this behaviour. | ||
| set(UNIFIED_RUNTIME_TAG 3e1a0ea44842b10cfdc0e1e98af2eee8fcd8e937) |
There was a problem hiding this comment.
There's already a newer tag, merged in: #16085 (comment). Please remove this change.
There was a problem hiding this comment.
Thanks, removed the change.
pbalcer
approved these changes
Nov 14, 2024
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Nov 14, 2024
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
added a commit
that referenced
this pull request
Dec 19, 2024
[PR#16056](#16056) fixed multi-device support for persistent cache but also changed format of the files in persistent cache - we used to write number of binaries before binary size and binary data but stopped doing that because we always have a single binary (for a single device) per file. Because of that new runtime stopped working with persistent cache created by older runtimes. This PR restores the old format of files in persistent cache. For that we need to write number of binaries to the file (before binary size and binary data) though it is always equal to 1 in current implementation. Even in the old implementation we could only put a single binary to the persistent cache in all scenarios, multi-device case wasn't supported, didn't have an API to create a program from multiple binaries. So we can assert that number of binaries is always 1 when reading from the cache.
KornevNikita
pushed a commit
that referenced
this pull request
Feb 25, 2025
[PR#16056](#16056) fixed multi-device support for persistent cache but also changed format of the files in persistent cache - we used to write number of binaries before binary size and binary data but stopped doing that because we always have a single binary (for a single device) per file. Because of that new runtime stopped working with persistent cache created by older runtimes. This PR restores the old format of files in persistent cache. For that we need to write number of binaries to the file (before binary size and binary data) though it is always equal to 1 in current implementation. Even in the old implementation we could only put a single binary to the persistent cache in all scenarios, multi-device case wasn't supported, didn't have an API to create a program from multiple binaries. So we can assert that number of binaries is always 1 when reading from the cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated UR PR: oneapi-src/unified-runtime#2313