-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][AMD] Propagate metadata in createURProgram #14831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SYCL properties weren't converted when calling creatreURProgram, leading to issue in finalization during KernelFusion for AMD.
address a regression introduced with moving to UR #14598 |
|
That wasn't an answer to your comment. But doesn't apply here as the issue is tracking multiple issues, only address one aspect. |
Just remembered that this PR should also reactivate this test: https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/NewOffloadDriver/diamond_shape.cpp |
Windows job failing for an unrelated reason
fyi @intel/dpcpp-devops-reviewers |
I restarted the runner ~1hr ago, should be fixed (tm). I'll restart the job here. |
The DeviceGlobal tests that were recently disabled are fixed by this change and can be reenabled:
|
reenabled |
ping @dpcpp-tools-reviewers |
@intel/llvm-gatekeepers the PR is ready to be merged |
SYCL properties weren't converted when calling creatreURProgram, leading to issue in finalization during KernelFusion for AMD. Fixes intel#14841
SYCL properties weren't converted when calling creatreURProgram, leading to issue in finalization during KernelFusion for AMD.
Fixes #14841