Bump UR tag to include PrintTrace fix #14728

callumfare · 2024-07-23T16:15:23Z

omarahmed1111 · 2024-07-31T11:54:01Z

@intel/dpcpp-esimd-reviewers Could we have a review on this when available ASAP to merge it? Thanks!

pbalcer · 2024-07-31T11:58:55Z

sycl/cmake/modules/FetchUnifiedRuntime.cmake

  # commit bc1a28ede0df7f837047b632e00437587672c134
  # Author: Omar Ahmed <[email protected]>
  # Date:   Mon Jul 29 16:44:58 2024 +0100
  #     Merge pull request #1819 from DBDuncan/sean/rename-interop-to-external
  #    [Bindless][Exp] Rename interop related structs/funcs with "external"
-  set(UNIFIED_RUNTIME_TAG bc1a28ede0df7f837047b632e00437587672c134)
+  set(UNIFIED_RUNTIME_TAG a2a053de43b8488a571ec026512a98b178ca06e4)


This was merged, so could be updated to oneapi-src/unified-runtime@3e762e0. This PR would then include all the updates from #14848.

omarahmed1111 · 2024-07-31T14:30:30Z

The bump for this PR will be included as part of this PR, so we could remove the UR bump here.

callumfare · 2024-07-31T14:44:41Z

The bump for this PR will be included as part of this PR, so we could remove the UR bump here.

The test changes (other than two Plugin tests) are all needed at the same time as the bump, because the UR changes cause the test output to be formatted differently on L0. So that PR would need to temporarily disable those tests on some configurations, and then reenable them here. It might be easier to merge this separately.

pbalcer · 2024-07-31T14:55:05Z

The bump for this PR will be included as part of this PR, so we could remove the UR bump here.

The test changes (other than two Plugin tests) are all needed at the same time as the bump, because the UR changes cause the test output to be formatted differently on L0. So that PR would need to temporarily disable those tests on some configurations, and then reenable them here. It might be easier to merge this separately.

Makes sense. This PR is nearly finished with CI anyway. I think this should be merged first, followed by #14701.

@intel/llvm-reviewers-runtime please review.

pbalcer · 2024-08-01T09:56:03Z

@intel/llvm-reviewers-runtime can you please approve? This PR only has test and UR related changes. The correct reviewer team should be @intel/unified-runtime-reviewers, but this PR was created before the CODEOWNERS file change.

maarquitos14

LGTM

maarquitos14 · 2024-08-01T09:59:44Z

sycl/test-e2e/Plugin/level_zero_dynamic_batch_test.cpp

@@ -1,6 +1,5 @@
 // REQUIRES: gpu, level_zero
-// TODO: Reenable, see https://github.com/intel/llvm/issues/14721
-// UNSUPPORTED: ze_debug, windows, linux
+// UNSUPPORTED: ze_debug


Not blocking the merge, but should this eventually be enabled? If so, please, create another issue for this.

I think it was always like that, even before PI removal.
See here.

@steffenlarsen and/or @lbushi25 are working on an ongoing effort to review all XFAIL and UNSUPPORTED directives in our e2e tests to add an explicit comment that those are either expected to be there due to our implementation status/device capabilities, or that those should be fixed as part of this or that tracker.

pbalcer · 2024-08-01T10:14:05Z

@intel/llvm-gatekeepers please merge

AlexeySachkov · 2024-08-01T10:31:35Z

sycl/test-e2e/Basic/host-task-dependency.cpp

@@ -178,15 +178,15 @@ int main() {
 }

 // launch of Gen kernel
-// CHECK:---> urKernelCreate(


This is not to block the PR, but my opinion is that we shouldn't have tests relying on tracing in e2e tests. Those should instead be refactored to be unit-tests. I've highlighted this already in PI removal PR and I would be happy to contribute to such rewrite myself (if only I had some time for it, sigh).

omarahmed1111 · 2024-08-01T10:35:22Z

Included PRs in this UR bump:

[L0] Implement IPC ops for L0 adapter oneapi-src/unified-runtime#1737
[Bindless][Exp] Create mapping of host and device handle oneapi-src/unified-runtime#1790
[CUDA][HIP] Return error on silently failing urEventGetInfo queries for interop created events oneapi-src/unified-runtime#1399
bump UMF tag to switch to rc2 release oneapi-src/unified-runtime#1908
Enable PrintTrace when SYCL UR tracing is enabled oneapi-src/unified-runtime#1884

Tests oneapi-src/unified-runtime#1884 Fixes intel#14704 Fixes intel#14721

callumfare mentioned this pull request Jul 23, 2024

Enable PrintTrace when SYCL UR tracing is enabled oneapi-src/unified-runtime#1884

Merged

callumfare temporarily deployed to WindowsCILock July 23, 2024 16:20 — with GitHub Actions Inactive

callumfare temporarily deployed to WindowsCILock July 23, 2024 17:50 — with GitHub Actions Inactive

callumfare force-pushed the callum/ur_printtrace_fix branch from 9766a9f to eb0b0d2 Compare July 24, 2024 08:51

callumfare temporarily deployed to WindowsCILock July 24, 2024 08:51 — with GitHub Actions Inactive

callumfare temporarily deployed to WindowsCILock July 24, 2024 09:23 — with GitHub Actions Inactive

omarahmed1111 force-pushed the callum/ur_printtrace_fix branch from eb0b0d2 to 7aa3d88 Compare July 30, 2024 13:28

omarahmed1111 had a problem deploying to WindowsCILock July 30, 2024 13:28 — with GitHub Actions Failure

omarahmed1111 had a problem deploying to WindowsCILock July 30, 2024 13:55 — with GitHub Actions Failure

omarahmed1111 temporarily deployed to WindowsCILock July 30, 2024 14:54 — with GitHub Actions Inactive

omarahmed1111 had a problem deploying to WindowsCILock July 30, 2024 16:22 — with GitHub Actions Failure

callumfare temporarily deployed to WindowsCILock July 31, 2024 09:11 — with GitHub Actions Inactive

callumfare had a problem deploying to WindowsCILock July 31, 2024 09:35 — with GitHub Actions Error

callumfare temporarily deployed to WindowsCILock July 31, 2024 09:43 — with GitHub Actions Inactive

callumfare added the pi-port label Jul 31, 2024

callumfare temporarily deployed to WindowsCILock July 31, 2024 10:07 — with GitHub Actions Inactive

omarahmed1111 marked this pull request as ready for review July 31, 2024 11:48

omarahmed1111 requested review from a team as code owners July 31, 2024 11:48

omarahmed1111 requested a review from dm-vodopyanov July 31, 2024 11:48

pbalcer reviewed Jul 31, 2024

View reviewed changes

callumfare added 4 commits July 31, 2024 13:16

Bump UR tag to include PrintTrace fix

006ec58

Fix E2E tests with L0 adapter tracing enabled

ff57a77

Reenable L0 batch e2e tests

2630186

Bump UR tag to include PrintTrace fix

e2bb05c

omarahmed1111 force-pushed the callum/ur_printtrace_fix branch from ec0f57a to e2bb05c Compare July 31, 2024 12:17

omarahmed1111 had a problem deploying to WindowsCILock July 31, 2024 12:19 — with GitHub Actions Failure

pbalcer approved these changes Jul 31, 2024

View reviewed changes

omarahmed1111 had a problem deploying to WindowsCILock July 31, 2024 12:43 — with GitHub Actions Failure

omarahmed1111 temporarily deployed to WindowsCILock July 31, 2024 13:40 — with GitHub Actions Inactive

sarnex approved these changes Jul 31, 2024

View reviewed changes

omarahmed1111 temporarily deployed to WindowsCILock July 31, 2024 14:26 — with GitHub Actions Inactive

maarquitos14 approved these changes Aug 1, 2024

View reviewed changes

AlexeySachkov reviewed Aug 1, 2024

View reviewed changes

AlexeySachkov merged commit 8411a7b into intel:sycl Aug 1, 2024
14 checks passed

AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024

Bump UR tag to include PrintTrace fix (intel#14728)

a0e2aa0

Tests oneapi-src/unified-runtime#1884 Fixes intel#14704 Fixes intel#14721

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bump UR tag to include PrintTrace fix #14728

Bump UR tag to include PrintTrace fix #14728

Uh oh!

callumfare commented Jul 23, 2024 •

edited

Loading

Uh oh!

omarahmed1111 commented Jul 31, 2024

Uh oh!

pbalcer Jul 31, 2024

Uh oh!

omarahmed1111 Jul 31, 2024

Uh oh!

omarahmed1111 commented Jul 31, 2024

Uh oh!

callumfare commented Jul 31, 2024

Uh oh!

pbalcer commented Jul 31, 2024

Uh oh!

pbalcer commented Aug 1, 2024

Uh oh!

maarquitos14 left a comment

Uh oh!

maarquitos14 Aug 1, 2024

Uh oh!

pbalcer Aug 1, 2024 •

edited

Loading

Uh oh!

AlexeySachkov Aug 1, 2024

Uh oh!

pbalcer commented Aug 1, 2024

Uh oh!

AlexeySachkov Aug 1, 2024

Uh oh!

Uh oh!

omarahmed1111 commented Aug 1, 2024

Uh oh!

Uh oh!

Bump UR tag to include PrintTrace fix #14728

Bump UR tag to include PrintTrace fix #14728

Uh oh!

Conversation

callumfare commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omarahmed1111 commented Jul 31, 2024

Uh oh!

pbalcer Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

omarahmed1111 Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

omarahmed1111 commented Jul 31, 2024

Uh oh!

callumfare commented Jul 31, 2024

Uh oh!

pbalcer commented Jul 31, 2024

Uh oh!

pbalcer commented Aug 1, 2024

Uh oh!

maarquitos14 left a comment

Choose a reason for hiding this comment

Uh oh!

maarquitos14 Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

pbalcer Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexeySachkov Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

pbalcer commented Aug 1, 2024

Uh oh!

AlexeySachkov Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

omarahmed1111 commented Aug 1, 2024

Uh oh!

Uh oh!

callumfare commented Jul 23, 2024 •

edited

Loading

pbalcer Aug 1, 2024 •

edited

Loading