Skip to content

[SYCL][ABI-Break] Drop legacy overload of queue::mem_advice #14618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[SYCL][ABI-Break] Drop legacy overload of queue::mem_advice #14618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions sycl/include/sycl/queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#include <sycl/detail/info_desc_helpers.hpp> // for is_queue_info_...
#include <sycl/detail/kernel_desc.hpp> // for KernelInfo
#include <sycl/detail/owner_less_base.hpp> // for OwnerLessBase
#include <sycl/detail/pi.h> // for pi_mem_advice
#include <sycl/device.hpp> // for device
#include <sycl/device_selector.hpp> // for device_selector
#include <sycl/event.hpp> // for event
Expand Down Expand Up @@ -687,18 +686,6 @@ class __SYCL_EXPORT queue : public detail::OwnerLessBase<queue> {
return this->memcpy(Dest, Src, Count * sizeof(T), DepEvents);
}

/// Provides additional information to the underlying runtime about how
/// different allocations are used.
///
/// \param Ptr is a USM pointer to the allocation.
/// \param Length is a number of bytes in the allocation.
/// \param Advice is a device-defined advice for the specified allocation.
/// \return an event representing advice operation.
__SYCL2020_DEPRECATED("use the overload with int Advice instead")
event mem_advise(
const void *Ptr, size_t Length, pi_mem_advice Advice,
const detail::code_location &CodeLoc = detail::code_location::current());

/// Provides additional information to the underlying runtime about how
/// different allocations are used.
///
Expand Down
6 changes: 0 additions & 6 deletions sycl/source/queue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,6 @@ event queue::memcpy(void *Dest, const void *Src, size_t Count,
/*CallerNeedsEvent=*/true, CodeLoc);
}

event queue::mem_advise(const void *Ptr, size_t Length, pi_mem_advice Advice,
const detail::code_location &CodeLoc) {
detail::tls_code_loc_t TlsCodeLocCapture(CodeLoc);
return mem_advise(Ptr, Length, int(Advice));
}

event queue::mem_advise(const void *Ptr, size_t Length, int Advice,
const detail::code_location &CodeLoc) {
detail::tls_code_loc_t TlsCodeLocCapture(CodeLoc);
Expand Down
1 change: 0 additions & 1 deletion sycl/test/abi/sycl_symbols_linux.dump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3124,7 +3124,6 @@ _ZN4sycl3_V15eventC1Ev
_ZN4sycl3_V15eventC2EP9_cl_eventRKNS0_7contextE
_ZN4sycl3_V15eventC2ESt10shared_ptrINS0_6detail10event_implEE
_ZN4sycl3_V15eventC2Ev
_ZN4sycl3_V15queue10mem_adviseEPKvm14_pi_mem_adviceRKNS0_6detail13code_locationE
_ZN4sycl3_V15queue10mem_adviseEPKvmiNS0_5eventERKNS0_6detail13code_locationE
_ZN4sycl3_V15queue10mem_adviseEPKvmiRKNS0_6detail13code_locationE
_ZN4sycl3_V15queue10mem_adviseEPKvmiRKSt6vectorINS0_5eventESaIS5_EERKNS0_6detail13code_locationE
Expand Down
1 change: 0 additions & 1 deletion sycl/test/abi/sycl_symbols_windows.dump
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4151,7 +4151,6 @@
?mem_advise@queue@_V1@sycl@@QEAA?AVevent@23@PEBX_KHAEBUcode_location@detail@23@@Z
?mem_advise@queue@_V1@sycl@@QEAA?AVevent@23@PEBX_KHAEBV?$vector@Vevent@_V1@sycl@@V?$allocator@Vevent@_V1@sycl@@@std@@@std@@AEBUcode_location@detail@23@@Z
?mem_advise@queue@_V1@sycl@@QEAA?AVevent@23@PEBX_KHV423@AEBUcode_location@detail@23@@Z
?mem_advise@queue@_V1@sycl@@QEAA?AVevent@23@PEBX_KW4_pi_mem_advice@@AEBUcode_location@detail@23@@Z
?memcpy@experimental@oneapi@ext@_V1@sycl@@YAXVqueue@45@PEAXPEBX_KAEBUcode_location@detail@45@@Z
?memcpy@handler@_V1@sycl@@QEAAXPEAXPEBX_K@Z
?memcpy@queue@_V1@sycl@@QEAA?AVevent@23@PEAXPEBX_KAEBUcode_location@detail@23@@Z
Expand Down
Loading