-
Notifications
You must be signed in to change notification settings - Fork 787
[WIP][SYCL] Replaces some of the CL_* enums with PI_* enums. #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
sub_group::store took T& for host and const T& for device. Signed-off-by: John Pennycook <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a couple of "C++ modernization" suggestions
This patch fixes a sporadic bug where one thread attempted to clean up a command already deleted by another. Signed-off-by: Sergey Semenov <[email protected]>
…ntel#1224) By default LLVM style limit code lines size to 80 characters. It should not be applied to LIT tests as clang-format can't preserve LIT commands semantic written in the code comments. This configuration file was shamelessly copied from the clang project. Signed-off-by: Alexey Bader <[email protected]>
…ions (intel#1219) Signed-off-by: James Brodman <[email protected]>
Signed-off-by: Vladimir Lazarev <[email protected]>
- deploy-lit.site.cfg configuration file used to owerwrite llvm-lit to use binaries from deploy, which sometimes do not exist. Removed deploy-lit.site.cfg and made all configuration files flexible using llvm-lit command line options. - check-all target used to run check-sycl-deploy target. This caused problems if CMAKE_INSTALL_PREFIX wasn't specified, because in this case check-sycl-deploy target leads to trying to install sycl binaries to system directories. Excluded check-sycl-deploy target from check-all. - Reduced copy-paste in check-sycl-deploy target dependencies. - Reduced number of variables passed from cmake to lit. Signed-off-by: Mariya Podchishchaeva <[email protected]>
If CUDA initialisation fails or there are no CUDA devices, do not return a CUDA-based SYCL platform rather than aborting or throwing an exception. Signed-off-by: Andrea Bocci <[email protected]>
Align `pi.h` formatting style with LLVM formatting style and rest of project. Signed-off-by: Bjoern Knafla <[email protected]>
Align the property parsing of `piContextCreate` with the way OpenCL properties are provided, i.e., a property list contains keys/IDs and values, never just a key/ID. Furthermore enable property lists that just contain a list terminating `0`. Introduce a PI type for context properties to untie from OpenCL. Adapt the SYCL runtime and tests accordingly. Signed-off-by: Bjoern Knafla <[email protected]>
Rehana Begam <[email protected]> Co-Authored-By: Alexey Bader <[email protected]>
Rehana Begam <[email protected]> Co-Authored-By: Alexey Bader <[email protected]>
) This PR fixes the following bugs: 1 Some times upon deletion, the deleted context would stay on the CUDA context stack and cause subsequent CUDA operations to fail. To fix this the context stack is now checked after destruction and if the dead context is still there it is removed. 2 In one location a ScopedContext was created without being assigned to a variable and would therefore die immediately. It should now live for the entirety of the surrounding scope. Signed-off-by: Steffen Larsen <[email protected]>
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
Signed-off-by: rbegam <[email protected]>
…m/llvm into private/rbegam/sycl-rename
@rbegam Please, remove commits not related to your patch form PR. |
@romanovvlad @bader @garimagu I'll close this one soon. |
Signed-off-by: Rehana Begam [email protected]