[CI] Switch pre-commit to a new scheme #10720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use pull_request trigger (instead of pull_request_trigger) for everything except AWS CUDA E2E testing. The latter has to go to a separate workflow (workflow_run) in order to have access to the AWS EC key kept as a github secret. As part of the changes I also stopped using matrix generator for the pre-commit task. Instead, the matrix is written directly inside the task's .yml file. The only minor difference in the behavior is that driver installation happens on an image with previous driver installed, not on a system without any driver.
|
Tested in #10715. |
stdale-intel
approved these changes
Aug 7, 2023
cperkinsintel
approved these changes
Aug 8, 2023
aelovikov-intel
added a commit
that referenced
this pull request
Aug 9, 2023
Linux had been updated in #10720 already.
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
Use pull_request trigger (instead of pull_request_target) for everything except AWS CUDA E2E testing. The latter has to go to a separate workflow (workflow_run) in order to have access to the AWS EC key kept as a github secret. As part of the changes, I also stopped using matrix generator for the pre-commit task. Instead, the matrix is written directly inside the task's .yml file. The only minor difference in the behavior is that driver installation happens on an image with previous driver installed, not on a system without any driver.
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…ntel#10767) Linux had been updated in intel#10720 already.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jan 23, 2025
That input parameter was introduced to `sycl-windows-build.yml` in intel#16560 but it's unclear why. Note that linux version has had it for quite some time, but we started unsetting it explicitly in intel#10720. The reason we had it for Linux in the first place is because `GITHUB_SHA` pointed to the PR's source branch for the `pull_request_target` trigger that we used at that time. With switching to `pull_request` trigger it became unnecessary as `GITHUB_SHA` points to the merge commit already. This change should fix current race condition when a post-commit CI job can test change landed after the current commit if there is a delay with runner allocation.
aelovikov-intel
added a commit
that referenced
this pull request
Jan 23, 2025
…16757) That input parameter was introduced to `sycl-windows-build.yml` in #16560 but it's unclear why. Note that linux version has had it for quite some time, but we started unsetting it explicitly in #10720. The reason we had it for Linux in the first place is because `GITHUB_SHA` pointed to the PR's source branch for the `pull_request_target` trigger that we used at that time. With switching to `pull_request` trigger it became unnecessary as `GITHUB_SHA` points to the merge commit already. This change should fix current race condition when a post-commit CI job can test change landed after the current commit if there is a delay with runner allocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pull_request trigger (instead of pull_request_target) for
everything except AWS CUDA E2E testing. The latter has to go to a
separate workflow (workflow_run) in order to have access to the AWS EC
key kept as a github secret.
As part of the changes, I also stopped using matrix generator for the
pre-commit task. Instead, the matrix is written directly inside the
task's .yml file. The only minor difference in the behavior is that
driver installation happens on an image with previous driver installed,
not on a system without any driver.