Skip to content

Do not diagnose unsupported __float128 type if it's not used in device code #943

Closed
@Fznamznon

Description

@Fznamznon

Now LLORG clang emits the following diagnostics from standard headers:

/usr/lib/gcc/x86_64-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_abs.h:102:7: error: __float128 is not supported on this target
  abs(__float128 __x)
      ^
/usr/lib/gcc/x86_64-linux-gnu/7.3.0/../../../../include/c++/7.3.0/bits/std_abs.h:101:3: error: __float128 is not supported on this target
  __float128

and so on.
We disabled such diagnostics for device by the following change:
#181 (comment)
Experiments show that we don't emit any diagnostics if __float128 is used in device code. IMO, that is not fully correct and this diagnostic should be delayed.

Metadata

Metadata

Assignees

Labels

upstreamThis change is related to upstreaming SYCL support to llorg.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions