[SYCL] 11 tests are failing on Ubuntu 18.10 and GCC 8.2.0

[keryell]

Current version bae2b75
has some failing tests on Ubuntu 18.10 and GCC 8.2.0:

********************
Failing Tests (11):
    SYCLUnitTests :: aot/with-llvm-bc.cpp
    SYCLUnitTests :: sub_group/barrier.cpp
    SYCLUnitTests :: sub_group/broadcast.cpp
    SYCLUnitTests :: sub_group/common.cpp
    SYCLUnitTests :: sub_group/common_ocl.cpp
    SYCLUnitTests :: sub_group/info.cpp
    SYCLUnitTests :: sub_group/load_store.cpp
    SYCLUnitTests :: sub_group/reduce.cpp
    SYCLUnitTests :: sub_group/scan.cpp
    SYCLUnitTests :: sub_group/shuffle.cpp
    SYCLUnitTests :: sub_group/vote.cpp

  Expected Passes    : 43607
  Expected Failures  : 172
  Unsupported Tests  : 1292
  Unexpected Failures: 11
make[3]: *** [CMakeFiles/check-all.dir/build.make:58: CMakeFiles/check-all] Error 1
make[2]: *** [CMakeFiles/Makefile2:211: CMakeFiles/check-all.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:218: CMakeFiles/check-all.dir/rule] Error 2
make: *** [Makefile:199: check-all] Error 2

Actually it is also mentionned by @Ruyk in #9

Among the 11, it looks like there are 2 kinds of failures:

FAIL: SYCLUnitTests :: aot/with-llvm-bc.cpp (45019 of 45082)
******************** TEST 'SYCLUnitTests :: aot/with-llvm-bc.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';    /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/clang -I/home/rkeryell/Xilinx/Projects/OpenCL/Khronos/OpenCL-Headers -fsycl -fsycl-targets=spir64-unknown-linux-sycldevice -c /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/aot/with-llvm-bc.cpp -o /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.o
: 'RUN: at line 2';    /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/clang -I/home/rkeryell/Xilinx/Projects/OpenCL/Khronos/OpenCL-Headers -fsycl -fsycl-link-targets=spir64-unknown-linux-sycldevice /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.o -o /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.spv
: 'RUN: at line 3';   /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/llvm-spirv -r /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.spv -o /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.bc
: 'RUN: at line 4';    /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/clang -I/home/rkeryell/Xilinx/Projects/OpenCL/Khronos/OpenCL-Headers -fsycl -fsycl-add-targets=binary:/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.bc /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.o -o /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.out -lOpenCL -lsycl -lstdc++
: 'RUN: at line 7';   env SYCL_DEVICE_TYPE=CPU  /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.out
--
Exit Code: -11

Command Output (stdout):
--
$ ":" "RUN: at line 1"
$ "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/clang" "-I/home/rkeryell/Xilinx/Projects/OpenCL/Khronos/OpenCL-Headers" "-fsycl" "-fsycl-targets=spir64-unknown-linux-sycldevice" "-c" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/aot/with-llvm-bc.cpp" "-o" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.o"
$ ":" "RUN: at line 2"
$ "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/clang" "-I/home/rkeryell/Xilinx/Projects/OpenCL/Khronos/OpenCL-Headers" "-fsycl" "-fsycl-link-targets=spir64-unknown-linux-sycldevice" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.o" "-o" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.spv"
$ ":" "RUN: at line 3"
$ "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/llvm-spirv" "-r" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.spv" "-o" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.bc"
$ ":" "RUN: at line 4"
$ "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/clang" "-I/home/rkeryell/Xilinx/Projects/OpenCL/Khronos/OpenCL-Headers" "-fsycl" "-fsycl-add-targets=binary:/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.bc" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.o" "-o" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.out" "-lOpenCL" "-lsycl" "-lstdc++"
$ ":" "RUN: at line 7"
$ "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/aot/Output/with-llvm-bc.cpp.tmp.out"
# command stderr:
Stack dump:
0.	Running pass 'Intel OpenCL Vectorizer' on module 'main'.
1.	Running pass 'Intel OpenCL VectorizerCore' on function ''
2.	Running pass 'OCL Builtin Pre Vectorization Pass' on function ''

error: command failed with exit status: -11

--

********************
FAIL: SYCLUnitTests :: sub_group/broadcast.cpp (45042 of 45082)
******************** TEST 'SYCLUnitTests :: sub_group/broadcast.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';    /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/clang -I/home/rkeryell/Xilinx/Projects/OpenCL/Khronos/OpenCL-Headers -std=c++11 -fsycl /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp -o /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/sub_group/Output/broadcast.cpp.tmp.out -lstdc++ -lOpenCL -lsycl
: 'RUN: at line 2';   env SYCL_DEVICE_TYPE=HOST /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/sub_group/Output/broadcast.cpp.tmp.out
: 'RUN: at line 3';   env SYCL_DEVICE_TYPE=CPU  /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/sub_group/Output/broadcast.cpp.tmp.out
: 'RUN: at line 4';    env SYCL_DEVICE_TYPE=GPU  /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/sub_group/Output/broadcast.cpp.tmp.out
: 'RUN: at line 5';   echo /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/sub_group/Output/broadcast.cpp.tmp.out
--
Exit Code: 1

Command Output (stdout):
--
$ ":" "RUN: at line 1"
$ "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/bin/clang" "-I/home/rkeryell/Xilinx/Projects/OpenCL/Khronos/OpenCL-Headers" "-std=c++11" "-fsycl" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp" "-o" "/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/build/projects/sycl/test/sub_group/Output/broadcast.cpp.tmp.out" "-lstdc++" "-lOpenCL" "-lsycl"
# command stderr:
In file included from /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:14:
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/helper.hpp:105:9: error: call to 'abs' is ambiguous
    if (std::abs(val - ref) != 0) {
        ^~~~~~~~
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:50:7: note: in instantiation of function template specialization 'exit_if_not_equal<unsigned int>' requested here
      exit_if_not_equal<T>(syclacc[j], L * WGid + SGid + SGid * sg_size,
      ^
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:65:3: note: in instantiation of function template specialization 'check<unsigned int>' requested here
  check<unsigned int>(Queue);
  ^
/usr/include/stdlib.h:837:12: note: candidate function
extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
           ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:56:3: note: candidate function
  abs(long __i) { return __builtin_labs(__i); }
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:61:3: note: candidate function
  abs(long long __x) { return __builtin_llabs (__x); }
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:70:3: note: candidate function
  abs(double __x)
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:74:3: note: candidate function
  abs(float __x)
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:78:3: note: candidate function
  abs(long double __x)
  ^
In file included from /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:14:
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/helper.hpp:105:9: error: call to 'abs' is ambiguous
    if (std::abs(val - ref) != 0) {
        ^~~~~~~~
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:50:7: note: in instantiation of function template specialization 'exit_if_not_equal<unsigned long>' requested here
      exit_if_not_equal<T>(syclacc[j], L * WGid + SGid + SGid * sg_size,
      ^
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:67:3: note: in instantiation of function template specialization 'check<unsigned long>' requested here
  check<unsigned long>(Queue);
  ^
/usr/include/stdlib.h:837:12: note: candidate function
extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
           ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:56:3: note: candidate function
  abs(long __i) { return __builtin_labs(__i); }
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:61:3: note: candidate function
  abs(long long __x) { return __builtin_llabs (__x); }
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:70:3: note: candidate function
  abs(double __x)
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:74:3: note: candidate function
  abs(float __x)
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:78:3: note: candidate function
  abs(long double __x)
  ^
2 errors generated.
In file included from /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:14:
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/helper.hpp:105:9: error: call to 'abs' is ambiguous
    if (std::abs(val - ref) != 0) {
        ^~~~~~~~
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:50:7: note: in instantiation of function template specialization 'exit_if_not_equal<unsigned int>' requested here
      exit_if_not_equal<T>(syclacc[j], L * WGid + SGid + SGid * sg_size,
      ^
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:65:3: note: in instantiation of function template specialization 'check<unsigned int>' requested here
  check<unsigned int>(Queue);
  ^
/usr/include/stdlib.h:837:12: note: candidate function
extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
           ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:56:3: note: candidate function
  abs(long __i) { return __builtin_labs(__i); }
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:61:3: note: candidate function
  abs(long long __x) { return __builtin_llabs (__x); }
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:70:3: note: candidate function
  abs(double __x)
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:74:3: note: candidate function
  abs(float __x)
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:78:3: note: candidate function
  abs(long double __x)
  ^
In file included from /home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:14:
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/helper.hpp:105:9: error: call to 'abs' is ambiguous
    if (std::abs(val - ref) != 0) {
        ^~~~~~~~
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:50:7: note: in instantiation of function template specialization 'exit_if_not_equal<unsigned long>' requested here
      exit_if_not_equal<T>(syclacc[j], L * WGid + SGid + SGid * sg_size,
      ^
/home/rkeryell/Xilinx/Projects/LLVM/worktrees/intel/sycl/sycl/test/sub_group/broadcast.cpp:67:3: note: in instantiation of function template specialization 'check<unsigned long>' requested here
  check<unsigned long>(Queue);
  ^
/usr/include/stdlib.h:837:12: note: candidate function
extern int abs (int __x) __THROW __attribute__ ((__const__)) __wur;
           ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:56:3: note: candidate function
  abs(long __i) { return __builtin_labs(__i); }
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:61:3: note: candidate function
  abs(long long __x) { return __builtin_llabs (__x); }
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:70:3: note: candidate function
  abs(double __x)
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:74:3: note: candidate function
  abs(float __x)
  ^
/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/std_abs.h:78:3: note: candidate function
  abs(long double __x)
  ^
2 errors generated.

error: command failed with exit status: 1
--
********************

[bader]

@vladimirlaz, could you take a look at these, please?

[Ruyk]

In case it helps, when using Ubuntu 18.04, GCC 7.3 and Intel CPU OpenCL 1.2.0.10, aot/with-llvm-bc.cpp deadlocks for me on clBuildProgram.

When I disable execution of that test, output is as below:

$ninja check-sycl
(.......)
********************
Testing Time: 44.30s
********************
Failing Tests (7):
    SYCLUnitTests :: sub_group/barrier.cpp
    SYCLUnitTests :: sub_group/broadcast.cpp
    SYCLUnitTests :: sub_group/common.cpp
    SYCLUnitTests :: sub_group/common_ocl.cpp
    SYCLUnitTests :: sub_group/reduce.cpp
    SYCLUnitTests :: sub_group/scan.cpp
    SYCLUnitTests :: sub_group/vote.cpp

  Expected Passes    : 43
  Expected Failures  : 1
  Unexpected Failures: 7

[pvchupin]

This seems to be an issue in version older (but the latest publicly available) of OpenCL CPU RT which is fixed now. We are working towards making a new OpenCL CPU RT release available soon and going to have more frequent updates going forward.

[bader]

There is a workaround for this issue: the problem is that SYCL device compiler saves information about source language as "OpenCL C++ 1.0" and OpenCL CPU runtime does not support C++ language yet, so it assumes that SPIR-V will require only OpenCL C 1.0 features.
The workaround could be raise the version in OpenCL language metadata to 2.1(?).

[bader]

@keryell, @Ruyk, could you check if Experimental Intel® CPU Runtime fixes these LIT test failures in your environment, please?

[keryell]

Since now I already switched on Ubuntu 19.04 and I am investigating some other failures there, perhaps @agozillon can test on his machine...

[agozillon]

I haven't had any failing tests in a long while with the cookie cutter GetStartedWithSYCLCompiler.md compile command, with either the experimental runtime or standard CPU runtime (I had some failing sub_group tests for a while as well, but they disappeared at some point in the distant past). I am using GCC 8.3 though, I could probably downgrade to test this tomorrow.

[bader]

Okay, it seems like you can't reproduce the issues @Ruyk experienced.
The issues reported by @keryell were fixed in February by #34, so if you don't have any failing LIT tests anymore - it's great, but a little bit puzzling... If you could share more information about your environment it would be great (e.g. what version of OpenCL CPU do you use).
To close this issue, I'll wait for a confirmation from @Ruyk, that no tests are failing in his environment.