Skip to content

[SYCL] Possibly redundant getSpirvSource() call in program_manager.cpp #26

Closed
@agozillon

Description

@agozillon

Fairly irrelevant issue and I could be wrong and misunderstanding the code (I apologize if I am) but I think the new addition of the function createOpenCLProgram inside sycl/source/detail/program_manager/program_manager.cpp makes the call to getSpirvSource() on line 125 inside the function getBuiltOpenCLProgram redundant.

As createOpenCLProgram calls it on line 115 (which is invoked by getBuiltOpenCLProgram) and the return from the invocation on line 125 doesn't appear to be used at the moment. The check for existing Spirv source inside getSpirvSource()probably stops the source getting loaded in twice but thought I'd bring it up in case.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions