[UR] Fix warnings in appendKernelLaunchWithArgsExpNew()

Fix following warnings in appendKernelLaunchWithArgsExpNew():

warning: cast from type ‘X’ to type ‘void*’ casts away qualifiers [-Wcast-qual]

Signed-off-by: Lukasz Dorau <[email protected]>

Author: ldorau

sycl/source/detail/scheduler/commands.cpp

@@ -2438,7 +2438,7 @@ static ur_result_t SetKernelParamsAndLaunch(
       case kernel_param_kind_t::kind_std_layout: {
         int Size = ParamDesc.info;
         ur_exp_kernel_arg_value_t Value = {};
-        Value.value = ArgPtr;
+        Value.value = const_cast<void *>(ArgPtr);
         UrArgs.push_back({UR_STRUCTURE_TYPE_EXP_KERNEL_ARG_PROPERTIES, nullptr,
                           UR_EXP_KERNEL_ARG_TYPE_VALUE,
                           static_cast<uint32_t>(NextTrueIndex),
@@ -2447,7 +2447,7 @@ static ur_result_t SetKernelParamsAndLaunch(
       }
       case kernel_param_kind_t::kind_pointer: {
         ur_exp_kernel_arg_value_t Value = {};
-        Value.pointer = *static_cast<const void *const *>(ArgPtr);
+        Value.pointer = *static_cast<void **>(const_cast<void *>(ArgPtr));
         UrArgs.push_back({UR_STRUCTURE_TYPE_EXP_KERNEL_ARG_PROPERTIES, nullptr,
                           UR_EXP_KERNEL_ARG_TYPE_POINTER,
                           static_cast<uint32_t>(NextTrueIndex),

unified-runtime/include/ur_api.h

@@ -46,13 +46,13 @@ desc: "Typesafe container for a kernel argument value"
 name: $x_exp_kernel_arg_value_t
 tag: $x_exp_kernel_arg_type_t
 members:
-    - type: "const void*"
+    - type: "void*"
       name: value
       desc: |
          [in] argument value represented as matching arg type.
          The data pointed to will be copied and therefore can be reused on return.
       tag: $X_EXP_KERNEL_ARG_TYPE_VALUE
-    - type: "const void*"
+    - type: "void*"
       name: pointer
       desc: "[in] Allocation obtained by USM allocation or virtual memory mapping operation, or pointer to a literal value."
       tag: $X_EXP_KERNEL_ARG_TYPE_POINTER

unified-runtime/scripts/core/exp-enqueue-kernel-launch-with-args.yml

@@ -1167,13 +1167,17 @@ ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExpNew(
   for (uint32_t argIndex = 0; argIndex < numArgs; argIndex++) {
     switch (pArgs[argIndex].type) {
     case UR_EXP_KERNEL_ARG_TYPE_LOCAL:
-      hKernel->kernelArgs[argIndex] = (void *)&pArgs[argIndex].size;
+      hKernel->kernelArgs[argIndex] =
+          reinterpret_cast<void *>(const_cast<size_t *>(&pArgs[argIndex].size));
       break;
     case UR_EXP_KERNEL_ARG_TYPE_VALUE:
-      hKernel->kernelArgs[argIndex] = (void *)pArgs[argIndex].value.value;
+      hKernel->kernelArgs[argIndex] = pArgs[argIndex].value.value;
       break;
     case UR_EXP_KERNEL_ARG_TYPE_POINTER:
-      hKernel->kernelArgs[argIndex] = (void *)&pArgs[argIndex].value.pointer;
+      // Casting is necessary here, since the argument
+      // is of the 'void * const *' type.
+      hKernel->kernelArgs[argIndex] = reinterpret_cast<void *>(
+          const_cast<void **>(&pArgs[argIndex].value.pointer));
       break;
     case UR_EXP_KERNEL_ARG_TYPE_MEM_OBJ:
       // prepareForSubmission() will save zePtr in kernelMemObj[argIndex]