Skip to content

Commit 2def4d8

Browse files
hdelanaelovikov-intelkbenzie
authored
[SYCL] Add test for extended deleters (#11344)
A typo in #10514 got rid of the extended deleter callbacks. This reinstates them. --------- Co-authored-by: aelovikov-intel <[email protected]> Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
1 parent 8cae553 commit 2def4d8

File tree

2 files changed

+25
-7
lines changed

2 files changed

+25
-7
lines changed

sycl/plugins/unified_runtime/CMakeLists.txt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
5151
include(FetchContent)
5252

5353
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
54-
#commit b38855ed815ffd076bfde5e5e06170ca4f723dc1
55-
#Merge: e6343f4 6a2c548
56-
#Author: Piotr Balcer <piotr.balcer@intel.com>
57-
#Date: Thu Oct 5 12:15:42 2023 +0200
58-
# Merge pull request #920 from jsji/localcopy
59-
# [UR][L0] Copy prebuilt L0 to avoid leaking shared folder path
60-
set(UNIFIED_RUNTIME_TAG b38855ed815ffd076bfde5e5e06170ca4f723dc1)
54+
# commit a76e3b185a5e1df9114dc483077227f88f522244
55+
# Merge: 3653e582 657ffde9
56+
# Author: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
57+
# Date: Fri Oct 20 12:12:15 2023 +0100
58+
# Merge pull request #972 from oneapi-src/revert-906-l0_usm_error_checking
59+
# Revert "[UR][L0] Propagate errors from `USMAllocationMakeResident`"
60+
set(UNIFIED_RUNTIME_TAG a76e3b185a5e1df9114dc483077227f88f522244)
6161

6262
if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO)
6363
set(UNIFIED_RUNTIME_REPO "${SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO}")
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
// REQUIRES: hip, cuda
2+
3+
// RUN: %{build} -o %t.out
4+
// RUN: %{run} %t.out | FileCheck %s
5+
6+
// CHECK: This extended deleter should be called at ctx destruction.
7+
8+
#include <sycl/sycl.hpp>
9+
10+
int main() {
11+
sycl::context c;
12+
sycl::detail::pi::contextSetExtendedDeleter(
13+
c,
14+
[](void *) {
15+
printf("This extended deleter should be called at ctx destruction.");
16+
},
17+
nullptr);
18+
}

0 commit comments

Comments
 (0)