Skip to content

Commit 1f4dc3d

Browse files
committed
[test] Update to v1.25.2 L0
Signed-off-by: Neil R. Spruit <[email protected]>
1 parent 066e266 commit 1f4dc3d

File tree

7 files changed

+26
-15
lines changed

7 files changed

+26
-15
lines changed

devops/dependencies.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@
1919
"root": "{DEPS_ROOT}/opencl/runtime/linux/oclgpu"
2020
},
2121
"level_zero": {
22-
"github_tag": "v1.24.3",
23-
"version": "v1.24.3",
24-
"url": "https://github.com/oneapi-src/level-zero/releases/tag/v1.24.3",
22+
"github_tag": "v1.25.2",
23+
"version": "v1.25.2",
24+
"url": "https://github.com/oneapi-src/level-zero/releases/tag/v1.25.2",
2525
"root": "{DEPS_ROOT}/opencl/runtime/linux/oclgpu"
2626
},
2727
"tbb": {

sycl/test-e2e/Adapters/level_zero/interop-image.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// REQUIRES: target-spir, level_zero, level_zero_dev_kit, aspect-ext_intel_legacy_image
22
// RUN: %{build} %level_zero_options -o %t.out
3-
// RUN: %{run} %t.out
3+
// RUN: env SYCL_UR_TRACE=-1 env ZE_ENABLE_LOADER_DEBUG_TRACE=1 env ZE_DEBUG=1 %{run} %t.out
44

55
// spir-v gen for legacy images at O0 not working
66
// UNSUPPORTED: O0

sycl/test-e2e/Adapters/level_zero/interop.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// REQUIRES: level_zero, level_zero_dev_kit
22
// RUN: %{build} %level_zero_options -o %t.out
3-
// RUN: env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{run} %t.out
3+
// RUN: env SYCL_UR_TRACE=-1 env ZE_ENABLE_LOADER_DEBUG_TRACE=1 env ZE_DEBUG=1 env SYCL_PI_LEVEL_ZERO_DEVICE_SCOPE_EVENTS=2 SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{run} %t.out
44
// UNSUPPORTED: ze_debug
55

66
// Test for Level Zero interop API

unified-runtime/cmake/FetchLevelZero.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ find_package(PkgConfig QUIET)
1313
# so try using that to find the install and if it's not available
1414
# just try to search for the path.
1515
if(PkgConfig_FOUND)
16-
pkg_check_modules(level-zero level-zero>=1.25.0)
16+
pkg_check_modules(level-zero level-zero>=1.25.2)
1717
if(level-zero_FOUND)
1818
set(LEVEL_ZERO_INCLUDE_DIR "${level-zero_INCLUDEDIR}/level_zero")
1919
set(LEVEL_ZERO_LIBRARY_SRC "${level-zero_LIBDIR}")
@@ -50,7 +50,7 @@ if(NOT LEVEL_ZERO_LIB_NAME AND NOT LEVEL_ZERO_LIBRARY)
5050
set(UR_LEVEL_ZERO_LOADER_REPO "https://github.com/oneapi-src/level-zero.git")
5151
# Remember to update the pkg_check_modules minimum version above when updating the
5252
# clone tag
53-
set(UR_LEVEL_ZERO_LOADER_TAG v1.25.0)
53+
set(UR_LEVEL_ZERO_LOADER_TAG v1.25.2)
5454

5555
# Disable due to a bug https://github.com/oneapi-src/level-zero/issues/104
5656
set(CMAKE_INCLUDE_CURRENT_DIR OFF)

unified-runtime/source/adapters/level_zero/platform.cpp

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -526,15 +526,22 @@ ur_result_t ur_platform_handle_t_::initialize() {
526526
ZeMemGetPitchFor2dImageExt.Supported =
527527
ZeMemGetPitchFor2dImageExt.zeMemGetPitchFor2dImage != nullptr;
528528

529-
ZE_CALL_NOCHECK(zeDriverGetExtensionFunctionAddress,
530-
(ZeDriver, "zeCommandListAppendLaunchKernelWithArguments",
531-
reinterpret_cast<void **>(
532-
&ZeCommandListAppendLaunchKernelWithArgumentsExt
533-
.zeCommandListAppendLaunchKernelWithArguments)));
529+
if (zeCommandListAppendLaunchKernelWithArguments && this->isDriverVersionNewerOrSimilar(1, 14, 35917)) {
530+
ZeCommandListAppendLaunchKernelWithArgumentsExt
531+
.zeCommandListAppendLaunchKernelWithArgumentsFunctionPtr =
532+
zeCommandListAppendLaunchKernelWithArguments;
533+
ZeCommandListAppendLaunchKernelWithArgumentsExt.Supported = true;
534+
} else {
535+
ZeCommandListAppendLaunchKernelWithArgumentsExt.Supported = false;
536+
}
534537

538+
printf("ur_platform_handle_t_::initialize: "
539+
"zeCommandListAppendLaunchKernelWithArguments ptr = %p\n",
540+
ZeCommandListAppendLaunchKernelWithArgumentsExt
541+
.zeCommandListAppendLaunchKernelWithArgumentsFunctionPtr);
535542
ZeCommandListAppendLaunchKernelWithArgumentsExt.Supported =
536543
ZeCommandListAppendLaunchKernelWithArgumentsExt
537-
.zeCommandListAppendLaunchKernelWithArguments != nullptr;
544+
.zeCommandListAppendLaunchKernelWithArgumentsFunctionPtr != nullptr;
538545

539546
// Check if the driver supports zeCommandListAppendLaunchKernelWithArguments()
540547
// with cooperative mode (version >= 1.6.35005)

unified-runtime/source/adapters/level_zero/platform.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ struct ur_platform_handle_t_ : ur::handle_base<ur::level_zero::ddi_getter>,
166166
struct ZeCommandListAppendLaunchKernelWithArgumentsExtension {
167167
bool Supported = false;
168168
bool DriverSupportsCooperativeKernelLaunchWithArgs = false;
169-
ze_result_t (*zeCommandListAppendLaunchKernelWithArguments)(
169+
ze_result_t (*zeCommandListAppendLaunchKernelWithArgumentsFunctionPtr)(
170170
ze_command_list_handle_t, ze_kernel_handle_t, const ze_group_count_t,
171171
const ze_group_size_t, void **, void *, ze_event_handle_t, uint32_t,
172172
ze_event_handle_t *);

unified-runtime/source/adapters/level_zero/v2/command_list_manager.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,10 +175,14 @@ ur_result_t ur_command_list_manager::appendKernelLaunchLocked(
175175
// zeCommandListAppendLaunchKernelWithArguments
176176
TRACK_SCOPE_LATENCY("ur_command_list_manager::"
177177
"zeCommandListAppendLaunchKernelWithArguments");
178+
printf("ur_command_list_manager::zeCommandListAppendLaunchKernelWithArguments %p\n",
179+
hContext->getPlatform()
180+
->ZeCommandListAppendLaunchKernelWithArgumentsExt
181+
.zeCommandListAppendLaunchKernelWithArgumentsFunctionPtr);
178182
ze_group_size_t groupSize = {WG[0], WG[1], WG[2]};
179183
ZE2UR_CALL(hContext->getPlatform()
180184
->ZeCommandListAppendLaunchKernelWithArgumentsExt
181-
.zeCommandListAppendLaunchKernelWithArguments,
185+
.zeCommandListAppendLaunchKernelWithArgumentsFunctionPtr,
182186
(getZeCommandList(), hZeKernel, zeThreadGroupDimensions,
183187
groupSize, hKernel->kernelArgs.data(), pNext, zeSignalEvent,
184188
waitListView.num, waitListView.handles));

0 commit comments

Comments
 (0)