[SYCL][ESIMD] Tests on Spec_Const feature for all basic types #135

fveselov · 2021-02-04T19:48:03Z

No description provided.

Co-authored-by: kbobrovs <[email protected]>

vladimirlaz · 2021-02-09T11:28:53Z

SYCL/ESIMD/spec_const/spec_const_ushort.cpp

+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+// TODO enable on Windows


The log looks like the case when unhandled exception if thrown from application.

Could you please add SYCL exception handling to the test: see examples in #63
to get extra information about failure.

fveselov · 2021-02-09T16:00:43Z

Adding SYCL exception handling does not change much. Most tests fail on Windows with no specific error:

[2021-02-09T15:11:40.860Z] 1 warning generated.
[2021-02-09T15:11:40.860Z]
[2021-02-09T15:11:40.860Z] $ ":" "RUN: at line 10"
[2021-02-09T15:11:40.860Z] $ "env" "SYCL_DEVICE_FILTER=opencl:gpu" "D:\Jenkins\llvm-test-suite_Jenkins\win_node\workspace\LLVM-Test-Suite-CI\LLVM-Test-Suite-WIN\build\SYCL\ESIMD\spec_const\Output\spec_const_int.cpp.tmp.out"
[2021-02-09T15:11:40.860Z] note: command had no output on stdout or stderr
[2021-02-09T15:11:40.860Z] error: command failed with exit status: 3221226505

Some tests (long and unsigned long) fail with errors:

[2021-02-09T15:23:32.247Z] D:\Jenkins\llvm-test-suite_Jenkins\win_node\workspace\LLVM-Test-Suite-CI\LLVM-Test-Suite-WIN\llvm-test-suite\SYCL\ESIMD\spec_const/Inputs/spec_const_common.hpp(48,38): error: constant expression evaluates to -99776644220011 which cannot be narrowed to type 'long' [-Wc++11-narrowing]
[2021-02-09T15:23:32.248Z] D:\Jenkins\llvm-test-suite_Jenkins\win_node\workspace\LLVM-Test-Suite-CI\LLVM-Test-Suite-WIN\llvm-test-suite\SYCL\ESIMD\spec_const/Inputs/spec_const_common.hpp(48,47): error: constant expression evaluates to 22001144668855 which cannot be narrowed to type 'long' [-Wc++11-narrowing]
[2021-02-09T15:23:32.248Z] D:/Jenkins/llvm-test-suite_Jenkins/win_node/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-WIN/llvm.obj/bin..\include\sycl\CL/sycl/INTEL/esimd/esimd_memory.hpp(235,3): error: static_assert failed due to requirement 'Sz >= __esimd::OWORD' "block size must be at least 1 oword"
[2021-02-09T15:23:32.249Z] D:/Jenkins/llvm-test-suite_Jenkins/win_node/workspace/LLVM-Test-Suite-CI/LLVM-Test-Suite-WIN/llvm.obj/bin..\include\sycl\CL/sycl/INTEL/esimd/esimd_memory.hpp(236,3): error: static_assert failed due to requirement 'Sz % __esimd::OWORD == 0' "block size must be whole number of owords"
[2021-02-09T15:23:32.249Z] 3 warnings and 4 errors generated.
[2021-02-09T15:23:32.249Z] error: command failed with exit status: 1

vladimirlaz · 2021-02-09T16:08:39Z

@fveselov I would like to ask you to analyze both issues. Are they known product issues or some test problem?
once the issues will be reported the test can be marked as XFAIL with corresponding comment.

SYCL/ESIMD/spec_const/Inputs/spec_const_common.hpp

SYCL/ESIMD/spec_const/spec_const_ulong.cpp

SYCL/ESIMD/spec_const/spec_const_ushort.cpp

kbobrovs · 2021-02-09T17:17:35Z

SYCL/ESIMD/spec_const/spec_const_uchar.cpp

+//
+//===----------------------------------------------------------------------===//
+// REQUIRES: gpu
+// XFAIL: level_zero || windows


why level_zero is XFAIL? please file a bug if it does not work on level_zero

kbobrovs · 2021-02-09T17:17:41Z

SYCL/ESIMD/spec_const/spec_const_short.cpp

+//
+//===----------------------------------------------------------------------===//
+// REQUIRES: gpu
+// XFAIL: level_zero || windows


why level_zero is XFAIL? please file a bug if it does not work on level_zero

SYCL/ESIMD/spec_const/spec_const_long.cpp

SYCL/ESIMD/spec_const/spec_const_bool.cpp

SYCL/ESIMD/spec_const/Inputs/spec_const_common.hpp

fveselov · 2021-02-09T23:10:30Z

@fveselov I would like to ask you to analyze both issues. Are they known product issues or some test problem?
once the issues will be reported the test can be marked as XFAIL with corresponding comment.

After previous changes long and ulong tests no longer fail with specific errors on windows. All tests fail the same way:

[2021-02-09T22:18:47.927Z] error: command failed with exit status: 3221226505

I'll investigate further to identify root of the issue with runs on windows.

fveselov · 2021-02-10T17:53:52Z

Specialization constants are not supported on Windows yet.

On Windows vector compute backend (as a part of IGC) uses llvm-7 and llvm-7 based spirv translator. This translator doesn't have the ability to overwrite the default specialization constant value. That is why the support in Windows driver is disabled at all.
This feature will start working on Windows when the llvm version is switched to 9.

Signed/unsigned char and short tests fail on Linux Level Zero with assertion:

/opt/src/build_igc/VectorCompiler/llvm-spirv-vc/lib/SPIRV/SPIRVReader.cpp:1350: llvm::Value* SPIRV::SPIRVToLLVM::transValueWithoutDecoration(SPIRV::SPIRVValue*, llvm::Function*, llvm::BasicBlock*, bool):
Assertion `(BT->getBitWidth() == 64 || (ConstValue >> BT->getBitWidth()) == 0) && "Size of externally provided specialization constant value doesn't" "fit into the specialization constant type"' failed.

tests have been marked accordingly.

kbobrovs · 2021-02-12T05:04:08Z

SYCL/ESIMD/spec_const/spec_const_long.cpp

@@ -0,0 +1,28 @@
+//==--------------- spec_const_long.cpp  - DPC++ ESIMD on-device test -----===//


please change the test name (int64)

kbobrovs · 2021-02-12T05:04:50Z

SYCL/ESIMD/spec_const/spec_const_ulong.cpp

@@ -0,0 +1,28 @@
+//==--------------- spec_const_ulong.cpp  - DPC++ ESIMD on-device test ----===//


please change the test name (uint64)

Auto pulldown and update tc files for xmain branch on 20210816

…llvm-test-suite#135)

fveselov and others added 21 commits December 4, 2020 01:03

ESIMD: add TPM tests

5d55ee2

[SYCL][ESIMD] TPM tests stylecheck fix

bb7498d

[SYCL][ESIMD] clang-format patch

59999ef

[SYCL][ESIMD] typo fix

68ee5ad

[SYCL][ESIMD] improve TPM tests self-check

7408568

[SYCL][ESIMD] add description to TPM tests; cosmetic changes

6c817ee

[SYCL][ESIMD] merged tests to one with 3 cases

8823c79

clang-format patch

f62acbc

cosmetic changes

ad93c1a

Update SYCL/ESIMD/tpm_tests.cpp

51319c8

Co-authored-by: kbobrovs <[email protected]>

reworked and renamed

b14db07

clang-format patch

9fe0151

[SYCL][ESIMD] evaluate condition on compile-time

f019b28

clang-format patch

d958a91

Merge branch 'intel' into intel

3461c8a

[SYCL][ESIMD] spec const tests for all basic types

544ac3f

Merge branch 'intel' into spec_const_tests

10fdec3

Update pm_access_1.cpp

d84e3b7

Update pm_access_2.cpp

a47856d

Update pm_access_3.cpp

309968d

clang-format patch

2061249

kbobrovs requested review from kbobrovs, AlexeySachkov and gmlueck February 4, 2021 20:42

fveselov added 6 commits February 5, 2021 05:11

more generalization

e6cc0d3

typo fix

371dd84

clang-format patch

c0684b9

cosmetic changes

04a4069

set expect fail

2772abb

enable windows

59cb60c

vladimirlaz suggested changes Feb 9, 2021

View reviewed changes

fveselov added 3 commits February 9, 2021 17:33

handle synchronous SYCL exceptions; remove unnecessary code; add comment

3635f1a

enable windows to run jenkins check(will be reverted)

6e482b2

set expect fail for Windows

845bd2a

kbobrovs suggested changes Feb 9, 2021

View reviewed changes

fveselov added 2 commits February 10, 2021 00:44

comments and C++ re-style

4bc6ca2

clang-format patch

cf53dd9

fveselov added 3 commits February 10, 2021 15:56

std exception handle

5441b64

move spec const init into try block

dc94ab4

set expect fail and unsupported status

bdcdc3c

fveselov requested review from kbobrovs and vladimirlaz February 10, 2021 19:22

fveselov added 2 commits February 11, 2021 15:37

add unsupported and xfail description

63237bd

cosmetic changes

dec0836

vladimirlaz previously approved these changes Feb 11, 2021

View reviewed changes

kbobrovs reviewed Feb 12, 2021

View reviewed changes

rename to int64

3ad7ffe

fveselov dismissed vladimirlaz’s stale review via 3ad7ffe February 12, 2021 10:59

cosmetic fix

d27ab0d

fveselov requested review from kbobrovs and vladimirlaz February 12, 2021 14:27

kbobrovs approved these changes Feb 12, 2021

View reviewed changes

vladimirlaz approved these changes Feb 15, 2021

View reviewed changes

vladimirlaz merged commit 6912242 into intel:intel Feb 15, 2021

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Apr 12, 2022

Merge pull request intel#135 from bb-sycl/xmain

63d32ae

Auto pulldown and update tc files for xmain branch on 20210816

aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023

[SYCL][ESIMD] Tests on Spec_Const feature for all basic types (intel/…

4a3def4

…llvm-test-suite#135)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SYCL][ESIMD] Tests on Spec_Const feature for all basic types #135

[SYCL][ESIMD] Tests on Spec_Const feature for all basic types #135

Uh oh!

fveselov commented Feb 4, 2021

Uh oh!

vladimirlaz Feb 9, 2021

Uh oh!

fveselov commented Feb 9, 2021

Uh oh!

vladimirlaz commented Feb 9, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kbobrovs Feb 9, 2021

Uh oh!

kbobrovs Feb 9, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fveselov commented Feb 9, 2021 •

edited

Loading

Uh oh!

fveselov commented Feb 10, 2021 •

edited

Loading

Uh oh!

kbobrovs Feb 12, 2021

Uh oh!

kbobrovs Feb 12, 2021

Uh oh!

Uh oh!

		@@ -0,0 +1,28 @@
		//==--------------- spec_const_long.cpp - DPC++ ESIMD on-device test -----===//

		@@ -0,0 +1,28 @@
		//==--------------- spec_const_ulong.cpp - DPC++ ESIMD on-device test ----===//

[SYCL][ESIMD] Tests on Spec_Const feature for all basic types #135

[SYCL][ESIMD] Tests on Spec_Const feature for all basic types #135

Uh oh!

Conversation

fveselov commented Feb 4, 2021

Uh oh!

vladimirlaz Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

fveselov commented Feb 9, 2021

Uh oh!

vladimirlaz commented Feb 9, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kbobrovs Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

kbobrovs Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fveselov commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fveselov commented Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kbobrovs Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

kbobrovs Feb 12, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fveselov commented Feb 9, 2021 •

edited

Loading

fveselov commented Feb 10, 2021 •

edited

Loading