Skip to content

Add non-exec stack annotation only for ELF #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

giordano
Copy link
Contributor

No description provided.

@eparshut
Copy link
Contributor

@giordano, Thanks for your contribution!
Your change makes sense for MacOS, however we are disabling PT support for MacOS since we have x86-specific assembly instructions. Do you need PT support for MacOS? Could you provide any details?

@giordano
Copy link
Contributor Author

I come from the Julia community and we still have some (admittedly not many at this point) still on Intel MacBook and would be nice to support them if possible. It's also good to know if this package doesn't support a certain platform anymore, but I think the REAMDE still suggests macOS (and Windows, too, also relevant for this PR) is supported.

@eparshut
Copy link
Contributor

I come from the Julia community and we still have some (admittedly not many at this point) still on Intel MacBook and would be nice to support them if possible. It's also good to know if this package doesn't support a certain platform anymore, but I think the REAMDE still suggests macOS (and Windows, too, also relevant for this PR) is supported.

Yes, that's right, we still claim macOS support, but not full functionality (except Intel PT).
The assembly sources from this PR are related to Intel PT support, and it can only be enabled in the library using a special build option (-pt). At the same time, for Windows we use different assembly sources.
Anyway, thanks again for your PR, it may help macOS users, I'll be happy to merge it!

@eparshut eparshut merged commit 03f7260 into intel:master Feb 27, 2025
16 checks passed
@giordano giordano deleted the mg/non-exec-stack-elf branch February 27, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants