Fix coverity issue in VC

vsemenov368 · igcbot · commit 8a939cf174d4 · 2025-09-16T16:10:19.000+02:00
.
diff --git a/IGC/VectorCompiler/lib/GenXCodeGen/GenXSimdCFConformance.cpp b/IGC/VectorCompiler/lib/GenXCodeGen/GenXSimdCFConformance.cpp
@@ -2088,8 +2088,8 @@ void GenXSimdCFConformance::lowerUnsuitableGetEMs() {
     }
 
     // Constants and non-EM values should be used directly
-    if (dyn_cast<Constant>(GetEMPred) ||
-        !getEMProducer(dyn_cast<Instruction>(GetEMPred), Visited)) {
+    if (auto *Inst = dyn_cast<Instruction>(GetEMPred);
+        isa<Constant>(GetEMPred) || Inst && !getEMProducer(Inst, Visited)) {
       GetEM->replaceAllUsesWith(GetEM->getOperand(0));
       ToDelete.push_back(GetEM);
     }

Original file line number	Diff line number	Diff line change
`@@ -2088,8 +2088,8 @@ void GenXSimdCFConformance::lowerUnsuitableGetEMs() {`
`2088`	`2088`	`}`
`2089`	`2089`
`2090`	`2090`	`// Constants and non-EM values should be used directly`
`2091`		`- if (dyn_cast<Constant>(GetEMPred) \|\|`
`2092`		`- !getEMProducer(dyn_cast<Instruction>(GetEMPred), Visited)) {`
	`2091`	`+ if (auto *Inst = dyn_cast<Instruction>(GetEMPred);`
	`2092`	`+ isa<Constant>(GetEMPred) \|\| Inst && !getEMProducer(Inst, Visited)) {`
`2093`	`2093`	`GetEM->replaceAllUsesWith(GetEM->getOperand(0));`
`2094`	`2094`	`ToDelete.push_back(GetEM);`
`2095`	`2095`	`}`