Skip to content

Prepare 0.26.1 #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 3, 2023
Merged

Prepare 0.26.1 #1399

merged 10 commits into from
May 3, 2023

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented May 2, 2023

Fixes: #1394

mythi and others added 6 commits May 2, 2023 09:29
When more than one device ID is Allocate()'d to a container,
Envs/Annotations for all but the last device ID get lost because
their cresp.* maps are (re-)instantiated on each loop.

Fix it by doing that only once.

Fixes: 55f3e17

Signed-off-by: Mikko Ylinen <[email protected]>
oneCCL requires the /dev/dri/by-path folder to be available
to create a mapping between GPUs.

Signed-off-by: Tuomas Katila <[email protected]>
In large clusters and with resource management, the load
from gpu-plugins can become heavy for the api-server.
This change will start fetching pod listings from kubelet
and use api-server as a backup. Any other error than timeout
will also move the logic back to using api-server.

Signed-off-by: Tuomas Katila <[email protected]>

Conflicts:
  deployments/gpu_plugin/base/intel-gpu-plugin.yaml
ninja-build is installed as a dependency to meson so we don't need to
install it separately. In fact pip install fails on setups that enforce
PEP-668 of externally managed environments.

Signed-off-by: Mikko Ylinen <[email protected]>
with docker 23.0.0, the builder defaults to Buildx which changed
how multi-stage builds are done. It looks the images used during
builds are no longer part of "docker images" which make the image
base layer test to fail:

Testing docker.io/intel/intel-deviceplugin-operator:devel base layer
Error: No such object: gcr.io/distroless/static
ERROR: failed to inspect gcr.io/distroless/static

Therefore, we must ensure gcr.io/distroless/static is pulled before
the image base layer is checked.

Signed-off-by: Mikko Ylinen <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #1399 (18bf870) into release-0.26 (d7a14ab) will decrease coverage by 0.29%.
The diff coverage is 43.54%.

❗ Current head 18bf870 differs from pull request most recent head 4e3ef52. Consider uploading reports for the commit 4e3ef52 to get more accurate results

@@               Coverage Diff                @@
##           release-0.26    #1399      +/-   ##
================================================
- Coverage         51.17%   50.89%   -0.29%     
================================================
  Files                44       44              
  Lines              4879     4985     +106     
================================================
+ Hits               2497     2537      +40     
- Misses             2239     2302      +63     
- Partials            143      146       +3     
Impacted Files Coverage Δ
pkg/controllers/reconciler.go 4.25% <ø> (ø)
cmd/gpu_plugin/rm/gpu_plugin_resource_manager.go 70.37% <16.66%> (-12.82%) ⬇️
cmd/gpu_plugin/gpu_plugin.go 87.21% <100.00%> (+2.26%) ⬆️
pkg/controllers/gpu/controller.go 36.64% <100.00%> (+0.67%) ⬆️
pkg/deviceplugin/server.go 83.33% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tkatila tkatila marked this pull request as ready for review May 2, 2023 14:30
mythi
mythi previously approved these changes May 2, 2023
@mythi mythi merged commit c17149f into intel:release-0.26 May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants