-
Notifications
You must be signed in to change notification settings - Fork 208
Prepare 0.26.1 #1399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Prepare 0.26.1 #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When more than one device ID is Allocate()'d to a container, Envs/Annotations for all but the last device ID get lost because their cresp.* maps are (re-)instantiated on each loop. Fix it by doing that only once. Fixes: 55f3e17 Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
oneCCL requires the /dev/dri/by-path folder to be available to create a mapping between GPUs. Signed-off-by: Tuomas Katila <[email protected]>
Signed-off-by: Ukri Niemimuukko <[email protected]>
In large clusters and with resource management, the load from gpu-plugins can become heavy for the api-server. This change will start fetching pod listings from kubelet and use api-server as a backup. Any other error than timeout will also move the logic back to using api-server. Signed-off-by: Tuomas Katila <[email protected]> Conflicts: deployments/gpu_plugin/base/intel-gpu-plugin.yaml
Signed-off-by: Mikko Ylinen <[email protected]>
ninja-build is installed as a dependency to meson so we don't need to install it separately. In fact pip install fails on setups that enforce PEP-668 of externally managed environments. Signed-off-by: Mikko Ylinen <[email protected]>
with docker 23.0.0, the builder defaults to Buildx which changed how multi-stage builds are done. It looks the images used during builds are no longer part of "docker images" which make the image base layer test to fail: Testing docker.io/intel/intel-deviceplugin-operator:devel base layer Error: No such object: gcr.io/distroless/static ERROR: failed to inspect gcr.io/distroless/static Therefore, we must ensure gcr.io/distroless/static is pulled before the image base layer is checked. Signed-off-by: Mikko Ylinen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-0.26 #1399 +/- ##
================================================
- Coverage 51.17% 50.89% -0.29%
================================================
Files 44 44
Lines 4879 4985 +106
================================================
+ Hits 2497 2537 +40
- Misses 2239 2302 +63
- Partials 143 146 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Tuomas Katila <[email protected]>
mythi
previously approved these changes
May 2, 2023
Signed-off-by: Tuomas Katila <[email protected]>
mythi
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1394