Skip to content

Add INSTALL.md with pointers to plugin and operator installation + new HELM instructions #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

tkatila
Copy link
Contributor

@tkatila tkatila commented Jan 20, 2023

In relation to issues #1312 and #1061

Signed-off-by: Tuomas Katila [email protected]

@tkatila tkatila changed the title gpu: Add helm install instructions WIP: gpu: Add helm install instructions Jan 20, 2023
@tkatila
Copy link
Contributor Author

tkatila commented Jan 20, 2023

I'll rewrite this as a more generic installation instructions.

@eero-t
Copy link
Contributor

eero-t commented Feb 8, 2023

I'll rewrite this as a more generic installation instructions.

Any news?

@tkatila
Copy link
Contributor Author

tkatila commented Feb 9, 2023

Any news?

It's coming still. I just had other items to work with.

@tkatila tkatila force-pushed the gpu-helm-installation branch from 11da6ac to 6ce55e6 Compare February 9, 2023 13:13
@tkatila tkatila changed the title WIP: gpu: Add helm install instructions Add INSTALL.md with pointers to plugin and operator installation + new HELM instructions Feb 9, 2023
@tkatila
Copy link
Contributor Author

tkatila commented Feb 9, 2023

In reference to #1061, I wasn't sure if these files should be also stripped from namespaces:
deployments/fpga_plugin/overlays/af/kustomization.yaml
deployments/sgx_admissionwebhook/overlays/default-with-certmanager/kustomization.yaml
deployments/sgx_plugin/overlays/epc-register/kustomization.yaml
deployments/sgx_plugin/overlays/epc-register/service-account.yaml

At least the intelfpgaplugin-system namespace is referred in shell scripts and READMEs.

@tkatila tkatila force-pushed the gpu-helm-installation branch 3 times, most recently from b6a7d8e to 017cba9 Compare February 10, 2023 08:26
@eero-t
Copy link
Contributor

eero-t commented Feb 10, 2023

/lgtm Doc looks good now (and I checked that all links are fine).

@tkatila tkatila force-pushed the gpu-helm-installation branch from 017cba9 to 423ebb0 Compare February 10, 2023 12:42
mythi
mythi previously approved these changes Feb 13, 2023
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait e2e-gpu to get back online

@mythi mythi merged commit 85563ec into intel:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants