-
Notifications
You must be signed in to change notification settings - Fork 63
G-UTILS-GPROFILER REWORK (5): Rework complex files #928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactor-into-g-utils-condensed
Are you sure you want to change the base?
G-UTILS-GPROFILER REWORK (5): Rework complex files #928
Conversation
…tils-condensed-complex
@granulatedekel I’m getting into this here |
Linter failure:
Probably due to bulk rename of modules without reordering. @granulatedekel will fix but I don't think that this blocks review. |
@YoniKF indeed minor fix - but it blocks tests from running, so we have no indication on breakages. |
from gprofiler.consts import CPU_PROFILING_MODE | ||
from gprofiler.platform import is_linux, is_windows | ||
from granulate_utils.gprofiler.platform import is_windows | ||
import granulate_utils.gprofiler.utils as _utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that moving run_process
to granulate-utils poses a problem, since in another PR we're adding more gprofiler-specific behavior to that function.
Part of the G-UTILS-GPROFILER REWORK saga - which aims to move away shared code from gprofiler to the g-utils project:
intel/granulate-utils#263 intel/granulate-utils#261 #925 #926 #926
This is the ultimate PR which is responsible for handling the last few files that required logical changes as well