Skip to content

chore(spell-check): add tool names to spelling allowlist #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Shrishti1701
Copy link
Contributor

Adds commonly used tool names like codecov, Codecov, and Dependabot to the spell check allowlist in .spelling/expect.txt.

This resolves false positives in the check-spelling workflow that were flagging these valid names as spelling errors.

Fixes #5044.

@terriko
Copy link
Contributor

terriko commented Apr 21, 2025

I'm going to update your branch since I had to merge that test fix PR earlier today.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, but I just realized: you've added words but the error was actually complaining that we had words that were no longer needed:

aiohttp cdx cwes getbootstrap GMS NOTKNOWN pyyaml rdf skontar spdx Svunknown urllib

are the ones it's recommending we remove.

See the "check spelling report" comment on #5042

@Shrishti1701
Copy link
Contributor Author

@terriko I've removed the words flagged as unnecessary in the spell-check report. Let me know if anything else needs to be updated!

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more request: looks like you've got the added terms in the wrong file. Can you merge those into .github/actions/spelling/expect.txt so this can be merged?

@Shrishti1701
Copy link
Contributor Author

Shrishti1701 commented Apr 24, 2025

Sure I'll do it right away.
And apologies for the confusion.

@Shrishti1701 Shrishti1701 requested a review from terriko April 24, 2025 19:10
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think whatever you did made it worse? We want all the changes in .github/actions/spelling/allow.txt (not expect.txt) so that should be the only file in this PR when it's ready.

@terriko
Copy link
Contributor

terriko commented Apr 28, 2025

Also, it's clear that you're really having some trouble with git. I'm not sure if it's because you're using a tool that's steering you wrong on how to make a pull request, but there are a number of tutorials out there and it might be worth spending some time following one if you're intending to do more software development. I recommend looking for a tutorial written before 2020 if you can -- there's been a lot of AI spam in this area but there used to be lots of good blog posts and stuff explaining how to fix pull requests.

@Shrishti1701
Copy link
Contributor Author

@terriko Hi terriko,
I'm really sorry for the confusion and for making the pull request more complicated than it needed to be. I'm still learning Git and the proper workflow, and I really appreciate your patience and clear feedback. I'll fix the pull request so that only .github/actions/spelling/allow.txt is changed as you asked.
I genuinely want to grow as a developer, and I’ll make sure to study more about Git and pull requests to improve. Thank you again for taking the time to help me!

@Shrishti1701 Shrishti1701 requested a review from terriko April 28, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: something up with spelling
2 participants