Skip to content

test: skip test_language_package in long tests #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

muddi900
Copy link
Contributor

@muddi900 muddi900 commented Aug 9, 2024

Description

closes #4322

Checklist

  • Add checker
  • Add test
  • Make sure long tests are passing
  • Add condensed downloads to the commit
  • Make sure all tests are passing
  • Make sure black/isort tests are passing
  • Run a manual test with a vulnerable version of the product
  • Update the template for this checker
  • Update the reference links

@muddi900 muddi900 changed the title test: test_language_package is not skipped if LONG_TEST is disabled.[Issue #4322] test: test_language_package is skipped if LONG_TEST is disabled.[Issue #4322] Aug 9, 2024
@terriko terriko changed the title test: test_language_package is skipped if LONG_TEST is disabled.[Issue #4322] test: skip test_language_package in long tests Aug 9, 2024
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited your PR title to fix the gitlint error (it was just a bit long) and there's an isort error below you'll need to fix before we can merge. But this looks good other than the linter issues! I initially thought "oh, it seems like such a pain to set each skip individually" but since I think we'll be slowly adding these back as we tune them having it done this way will make that a lot easier, so thank you for that.

@terriko
Copy link
Contributor

terriko commented Aug 9, 2024

Oh, and if you need more info on the linters, that's here in the contributor docs: https://cve-bin-tool.readthedocs.io/en/latest/CONTRIBUTING.html#running-linters

@terriko
Copy link
Contributor

terriko commented Aug 12, 2024

Ugh, looks like merging the new language tests broke this and I wasn't able to fix it during the merge conflict resolution. I'm going to flag it for me to look at it tomorrow, since I'm unlikely to get to it today.

@terriko terriko added awaiting maintainer Need a maintainer to respond / help out and removed awaiting CI labels Aug 12, 2024
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like when I did the merge i accidentally deleted the parser lines added in by the other PR, so as a result the test broke. I'm doing some testing on my local machine to make sure I'm right about the fix, but in the meantime if you want to fix your branch I've got one suggestion below and you can probably figure out what the others need to look like.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so it's definitely a problem where the merge missed adding the parser name as the second argument. (You can see it as deleted lines in the diff right now) Fixing that second argument allows the new part of the test to run and the disabling still works as expected.

It doesn't look like I can fix this PR for you from the web interface, so I'd very much appreciate it if you could add those in! Note that because of the merge your local branch is probably showing as out of date with the github branch this PR is based on so you've got a few options:

  1. git pull from your remote branch into your local branch to get them back into sync then push a fix that adds the parsers in as second argument.
  2. make a new branch / new PR and skip dealing with getting them in sync
  3. fix your local branch and git push -f to this one to over-write the merge that didn't work perfectly

Probably the 1st is the easiest option?

If you can't get to it over the next couple of days or syncing git branches is too much darned work and you'd like me to handle it for you, let me know and I'll see what I can do.

@terriko terriko added awaiting submitter Need more information from submitter and removed awaiting maintainer Need a maintainer to respond / help out labels Aug 15, 2024
@muddi900
Copy link
Contributor Author

What is up with the triage.json showing up once I sync any branch.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the triage.json is related to another PR -- github is showing the diff probably because of the way things were merged. It makes code review a bit more annoying but shouldn't impact getting this merged.

Thank you for iterating on this with me! Looks like the tests are all behaving as expected now, so let's get this merged!

@terriko terriko merged commit bceb2c0 into intel:main Aug 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting submitter Need more information from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: move language scanner tests to longtests
2 participants