Skip to content

feat(checker): add ttyd checker #4031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

ffontaine
Copy link
Contributor

No description provided.

@terriko
Copy link
Contributor

terriko commented Apr 16, 2024

re-running tests now that yesterday's data issue seems to be resolved.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure on windows actually looks related:

=========================== short test summary info ===========================
FAILED test/test_scanner.py::TestScanner::test_version_mapping[ttyd-1.6.3-version_strings516] - AssertionError: assert 'ttyd' in set()
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://rpmfind.net/linux/opensuse/ports/aarch64/tumbleweed/repo/oss/aarch64/-ttyd-1.7.4-1.3.aarch64.rpm-ttyd-1.7.4-other_products1058] - AssertionError: ttyd not found in ttyd-1.7.4-1.3.aarch64.rpm.
          The checker signature or url may be incorrect.
assert 'ttyd' in set()
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://ftp.fr.debian.org/debian/pool/main/t/ttyd/-ttyd_1.6.3-3~bpo11+1_amd64.deb-ttyd-1.6.3-other_products1059] - AssertionError: ttyd not found in ttyd_1.6.3-3~bpo11+1_amd64.deb.
          The checker signature or url may be incorrect.
assert 'ttyd' in set()
FAILED test/test_scanner.py::TestScanner::test_version_in_package[https://downloads.openwrt.org/releases/packages-19.07/x86_64/packages/-ttyd_1.5.2-2_x86_64.ipk-ttyd-1.5.2-other_products1060] - AssertionError: ttyd not found in ttyd_1.5.2-2_x86_64.ipk.
          The checker signature or url may be incorrect.
assert 'ttyd' in set()
===== 4 failed, 1990 passed, 33 skipped, 6 warnings in 1545.67s (0:25:45) =====

class TtydChecker(Checker):
CONTAINS_PATTERNS: list[str] = []
FILENAME_PATTERNS: list[str] = []
VERSION_PATTERNS = [r"([0-9]+\.[0-9]+\.[0-9]+)[a-z\n\n]*ttyd"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
VERSION_PATTERNS = [r"([0-9]+\.[0-9]+\.[0-9]+)[a-z\n\n]*ttyd"]
VERSION_PATTERNS = [r"([0-9]+\.[0-9]+\.[0-9]+)[a-z\n\r]*ttyd"]

My guess is that windows is complaining about lack of \r here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I updated PR

Signed-off-by: Fabrice Fontaine <[email protected]>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge time. Thanks!

@terriko terriko merged commit 8e1b878 into intel:main Apr 17, 2024
22 checks passed
@ffontaine ffontaine deleted the add-ttyd-checker branch April 18, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants