-
Notifications
You must be signed in to change notification settings - Fork 531
feat(checker): add ttyd checker #4031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
re-running tests now that yesterday's data issue seems to be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failure on windows actually looks related:
=========================== short test summary info ===========================
FAILED test/test_scanner.py::TestScanner::test_version_mapping[ttyd-1.6.3-version_strings516] - AssertionError: assert 'ttyd' in set()
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://rpmfind.net/linux/opensuse/ports/aarch64/tumbleweed/repo/oss/aarch64/-ttyd-1.7.4-1.3.aarch64.rpm-ttyd-1.7.4-other_products1058] - AssertionError: ttyd not found in ttyd-1.7.4-1.3.aarch64.rpm.
The checker signature or url may be incorrect.
assert 'ttyd' in set()
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://ftp.fr.debian.org/debian/pool/main/t/ttyd/-ttyd_1.6.3-3~bpo11+1_amd64.deb-ttyd-1.6.3-other_products1059] - AssertionError: ttyd not found in ttyd_1.6.3-3~bpo11+1_amd64.deb.
The checker signature or url may be incorrect.
assert 'ttyd' in set()
FAILED test/test_scanner.py::TestScanner::test_version_in_package[https://downloads.openwrt.org/releases/packages-19.07/x86_64/packages/-ttyd_1.5.2-2_x86_64.ipk-ttyd-1.5.2-other_products1060] - AssertionError: ttyd not found in ttyd_1.5.2-2_x86_64.ipk.
The checker signature or url may be incorrect.
assert 'ttyd' in set()
===== 4 failed, 1990 passed, 33 skipped, 6 warnings in 1545.67s (0:25:45) =====
cve_bin_tool/checkers/ttyd.py
Outdated
class TtydChecker(Checker): | ||
CONTAINS_PATTERNS: list[str] = [] | ||
FILENAME_PATTERNS: list[str] = [] | ||
VERSION_PATTERNS = [r"([0-9]+\.[0-9]+\.[0-9]+)[a-z\n\n]*ttyd"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VERSION_PATTERNS = [r"([0-9]+\.[0-9]+\.[0-9]+)[a-z\n\n]*ttyd"] | |
VERSION_PATTERNS = [r"([0-9]+\.[0-9]+\.[0-9]+)[a-z\n\r]*ttyd"] |
My guess is that windows is complaining about lack of \r here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I updated PR
Signed-off-by: Fabrice Fontaine <[email protected]>
0fe09e2
to
61e4814
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge time. Thanks!
No description provided.