database error - metric_id foreign key not found

[steven-hh-ding]

cve-bin-tool/cve_bin_tool/cvedb.py

Lines 104 to 118 in 0b051df

	CREATE TABLE IF NOT EXISTS cve_metrics (
	cve_number TEXT,
	metric_id INTEGER,
	metric_score REAL,
	metric_field TEXT,
	FOREIGN KEY(cve_number) REFERENCES cve_severity(cve_number),
	FOREIGN KEY(metric_id) REFERENCES metrics(metric_id)
	)
	""",
	"metrics": """
	CREATE TABLE IF NOT EXISTS metrics (
	metrics_id INTEGER,
	metrics_name TEXT,
	PRIMARY KEY(metrics_id)
	)

Hi, just wonder shouldn't line 115 be metric_id rather than metrics_id? Thanks

[terriko]

Hm, good find. That probably should be consistent.

[steven-hh-ding]

I guess it is easier to change line 110 - I updated in my fork and it seems fine

[terriko]

Do you mind pushing up a PR with that change, or do you want me to do it?

[steven-hh-ding]

Yah I can just do it - but wasn't sure if that was an actual bug or not. I will just change the foreign key.

[terriko]

Definitely a mistake, just unfortunately it was the type that made things a bit slower than they could have been rather than something that was really easy for the person who made the typo to notice. Look forwards to seeing your PR! If you need any help setting it up, the contributor docs are here: https://cve-bin-tool.readthedocs.io/en/latest/CONTRIBUTING.html But don't worry too much about them if they look overwhelming for a one line PR. I can fix stuff during merge if needed.

[steven-hh-ding]

We find this error when integrating cve-bin-tool to langchain - sqlalchemy throws us the error otherwise almost impossible to see.

We use llm to generate a lot more checkers for cve-bin-tool, will be sending out a PR on that soon. Thanks for the quick confirmation.