Skip to content

fix: Add log messages about mirror availability. #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
terriko opened this issue Apr 16, 2024 · 0 comments · Fixed by #4352
Closed

fix: Add log messages about mirror availability. #4037

terriko opened this issue Apr 16, 2024 · 0 comments · Fixed by #4352
Milestone

Comments

@terriko
Copy link
Contributor

terriko commented Apr 16, 2024

I'd like to communicate to people using the nvd_api_key that they could switch to using the mirror and how and why.

  • The why might be a bit long for a log message, but reasons include faster updates, no rate limiting, worldwide mirrors.
  • The downsides include being a few hours out of date compared to nvd.
  • May need some more extensive documentation to support a short log message with a link
  • Recall: right now when the 3.3 release comes out, the mirrors will be available to pypi users for the first time, but most of them will already be using nvd_api_key settings so they may not use the mirror without prompting (and many may want to if they understand it's available!)
@terriko terriko added this to the 3.3.1 milestone Apr 17, 2024
terriko added a commit that referenced this issue Aug 15, 2024
- Adds log info messages about the mirrors
- Updates the manual to include more explanation of the mirror option
- Fix some logic around when we display a message about the nvd_api_key
- Switch so having an nvd_api_key doesn't automatically switch you to api2 (this turned out to be surprising in cases of people trying out the mirror)
- fixes #4037
- ci: try extra recommended dictionaries

---------

Signed-off-by: Terri Oda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant