Skip to content

chore: use unique tempdir prefixes in fuzzing temp dirs #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
terriko opened this issue Mar 20, 2024 · 1 comment · Fixed by #4022
Closed

chore: use unique tempdir prefixes in fuzzing temp dirs #3960

terriko opened this issue Mar 20, 2024 · 1 comment · Fixed by #4022
Labels
good first issue Good for newcomers

Comments

@terriko
Copy link
Contributor

terriko commented Mar 20, 2024

We've been working on improving our discipline around temp directories in fuzzing and making sure they get cleaned up appropriately, but it occurred to me yesterday during code review that it might be useful to use a different prefix for the fuzzing than we do for regular cve-bin-tool actions, mostly to help developers make sure we're cleaning up temp files directly.

For #3944 I suggested using the prefix "cve-bin-tool-fuzz-renv-" (previously the prefix was "cve-bin-tool-"). We should probably change the others to match. This isn't urgent and should be pretty easy for a beginner to do, so I'm going to flag this as a beginner friendly bug.

What to do:

  • look at the python files in the fuzz/ directory
  • if they create a temp directory with the prefix "cve-bin-tool", change that prefix to be "cve-bin-tool-fuzz-FUZZERNAME" where FUZZERNAME should be replaced with something that identifies the fuzzer in question.

For those of you working on otherwise improving our fuzzers, feel free to make these changes alongside the temp cleanup stuff, but otherwise let's leave this open for a beginner to get their first commit with us.

@terriko terriko added the good first issue Good for newcomers label Mar 20, 2024
@ashish111333
Copy link

Hi there,I would like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants