Add compiler packages to list of packages in Stackage LTS #83
Conversation
| @@ -76,3 +78,5 @@ lts2plan compilerPackagesMap lts = Plan { packages, compilerVersion, compilerPac | |||
| _ -> Nothing | |||
| , packageFlags = Map.lookupDefault Map.empty name flags | |||
| }) | |||
|
|
|||
| packages = packages' `Map.union` compilerPackages' | |||
There was a problem hiding this comment.
I think we want the union the other way around. If packages provides overrides for the compilerPackages, we want them to override those, not rely on the compilerPackages.
There was a problem hiding this comment.
This was my idea too. According to the docs:
The union of two maps. If a key occurs in both maps, the mapping from the first will be the mapping in the result.
so packages' has preference over compilerPackages'.
There was a problem hiding this comment.
Ohh... that's somewhat counter intuitive... thanks!
|
By the way, it would be great if the Nix expressions for LTS 15.x in the |
Yep. This will need some wrangling, but certainly needs doing! |
As described in input-output-hk/haskell.nix#481, the import logic for the new Stackage format does not include the "compiler packages" as provided by the snapshot. This PR fixes that logic by including those packages with their default revisions.