-
Notifications
You must be signed in to change notification settings - Fork 29
New node tracing system support #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnalotoski
wants to merge
19
commits into
master
Choose a base branch
from
jl/new-tracing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b0b049
to
599a336
Compare
8bf6d9c
to
8b306d6
Compare
72c248d
to
b83a994
Compare
b30873e
to
b62f65f
Compare
mgmeier
reviewed
Apr 23, 2025
LGTM minus the one non-existing config option. I think it would be a nice touch to add comments everywhere, as the nix svc is meant to be a generic one. Also I hope it clarifies that settings on |
mgmeier
reviewed
Apr 23, 2025
00e1506
to
1abea58
Compare
* Update usePeersFromLedgerAfterSlot to useLedgerAfterSlot for consistent naming with the cardano-node topology file key. * It would be nice to put a deprecated warn for the legacy name in the environment for some time before removing it, but with eager evaluation of the cardanoLib environment set, either everybody sees the warn if present, or nobody does if missing. Since grep.app doesn't find any downstream uses of the legacy name beyond the repos already being updated, we'll simply remove the legacy named attr now.
1abea58
to
8319cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default tracing system to the new tracing system and implements support for this where needed:
For Cardano-lib:
nodeConfig
andnodeConfigBp
now are populated with new tracing system configurationnodeConfigLegacy
andnodeConfigBpLegacy
are available until the legacy tracing system is removed from nodetracerConfig
is available, for use with cardano-tracerdefaultLogConfigLegacy
anddefaultTracerConfig
mkConfigHtml
function has been updated to include legacy configuration files,$ENV-config-legacy.json
and$ENV-config-bp-legacy.json
, and a new tracer config file,$ENV-tracer-config.json
For generic log config:
cardano-lib/generic-log-config.nix
now holds new tracing system default config instead of legacy configFor generic tracing config:
cardano-lib/generic-tracer-config.nix
now holds tracing system default configFor testnet template config:
cardano-lib/testnet-template/config.json
now holds new tracing system template config instead of legacy configFor legacy generic log config:
cardano-lib/generic-log-config-legacy.nix
now holds legacy tracing system default configFor legacy testnet template config:
cardano-lib/testnet-template/config-legacy.json
now holds legacy tracing system template configOther changes include:
usePeersFromLedgerAfterSlot
has been renamed touseLedgerAfterSlot
for consistency with the topology file key value it sets. A corresponding change has been made in the nixos cardano-node service.topology.yaml
totopology.json
to reflect json contents.bomutils
andnixWrapped
util.