Skip to content

Add niv sources at haskell-nix.sources #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2020
Merged

Add niv sources at haskell-nix.sources #622

merged 4 commits into from
May 21, 2020

Conversation

hamishmack
Copy link
Collaborator

I think it would be nice to be able to use niv to manage sources. I
like niv update to bump to latest version or switch branches.
It is easy enough to modify the nix/sources.json manually if anyone
does not want to learn a new tool and since @michaelpj already added
a niv like sources very little changes. I have exposed the
sources as haskell-nix.sources so that we can get at it from
wherever we need it.

I've just put the nixpkgs pins in nix/sources.json for now and
we can add things too it as we need to update them.

I think it would be nice to be able to use niv to manage sources. I
like `niv update` to bump to latest version or switch branches.
It is easy enough to modify the `nix/sources.json` manually if anyone
does not want to learn a new tool and since @michaelpj already added
a niv like `sources` very little changes.  I have exposed the
`sources` as `haskell-nix.sources` so that we can get at it from
wherever we need it.

I've just put the `nixpkgs` pins in `nix/sources.json` for now and
we can add things too it as we need to update them.
@hamishmack
Copy link
Collaborator Author

Let's just add the current hackage and stackage to haskell-nix.sources and use that as the source of truth.

If we have:

sources = { inherit hackage stackage; } // (import ./nix/sources.nix) // sourcesOverrides;

We can use sourcesOverride and niv add to pin different versions, but niv update will not work until the scripts are updated.

@hamishmack hamishmack requested a review from angerman May 20, 2020 14:57
# Conflicts:
#	default.nix
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@hamishmack hamishmack merged commit 74915fa into master May 21, 2020
@iohk-bors iohk-bors bot deleted the hkm/niv branch May 21, 2020 03:39
@angerman angerman mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants