fix targetPrefix in cabal-pkg-config #1838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some vars moved from attrs to attrs.env in nixpkgs adc8900d. Accomodate both locations. - Fixes case 1837
|
Looks like one of the tests broke before it started. Rerun tests maybe? |
|
There was a fix for this coming in #1815, but I like this fix better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targetPrefixandbaseBinNamechanged locations across NixOS/nixpkgs@adc8900 . This PR allowscabal-pkg-configto work with nixpkgs before and after the above commit.Fixes case #1837 .