Update main.yml #204
Merged
Update main.yml #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillespie
reviewed
Feb 5, 2025
| @@ -0,0 +1,49 @@ | |||
| name: Container Upload Workflow | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
Where is this workflow used?
There was a problem hiding this comment.
Good catch, this is a left over when I tried to make this work with workflow_call, but that was rather iffy.
sgillespie
reviewed
Feb 5, 2025
.github/workflows/build-and-test.yml
Outdated
| @@ -1,118 +1,118 @@ | |||
| name: Build and Test | |||
| # name: Build and Test | |||
There was a problem hiding this comment.
Why don't we just remove this?
There was a problem hiding this comment.
Ohh, I commented this just out to focus on the other part, we should bring it back once the container upload works. I'm still wondering if we should chain it to it. So we actually test the containers we build.
|
Also, it looks like we have another notification problem: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.