Patch "HLS stuck (init then no progress) since multi home support" #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillespie
reviewed
Apr 22, 2024
tool-map.nix
Outdated
| configureArgs = "--disable-benchmarks --disable-tests"; | ||
| modules = [{ | ||
| packages.ghcide.patches = [ | ||
| # https://github.com/haskell/haskell-language-server/issues/4046#issuecomment-1926242056 |
There was a problem hiding this comment.
I've only got this working with hls-2.6 (2.7 definitely did not work), but I suspect it won't work with hls <= 2.4. Have you tested on 2.2 and 2.4?
EDIT: This indeed seems to be a problem on ghc90,ghc810 builds: https://ci.zw3rk.com/build/4619453/nixlog/1
yvan-sraka
force-pushed
the
fix-slow-hls
branch
from
a320d2d to
be54c59
Compare
sgillespie
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. haskell/haskell-language-server#4046
The problem could be observed with this demo project https://github.com/sgillespie/cardano-dev-hls/tree/main