Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Disable terminal GUI on Windows #330

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Disable terminal GUI on Windows #330

merged 1 commit into from
Oct 23, 2019

Conversation

HirotoShioi
Copy link
Contributor

@HirotoShioi HirotoShioi added the wip Work In Progress label Oct 23, 2019
@HirotoShioi HirotoShioi self-assigned this Oct 23, 2019
ksaric
ksaric approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@ksaric ksaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

cardano-launcher/cardano-launcher.cabal
, Cabal

if os(windows)
ghc-options: -optl-mwindows
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compile and link the code as a windows executable (WinMain)?

@ksaric ksaric merged commit cd154b0 into master Oct 23, 2019
@ksaric ksaric deleted the hiroto/GH-329 branch October 23, 2019 10:24
@HirotoShioi HirotoShioi removed the wip Work In Progress label Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ksaric ksaric ksaric approved these changes

@erikd erikd Awaiting requested review from erikd erikd is a code owner

Assignees

@HirotoShioi HirotoShioi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HirotoShioi @ksaric