Skip to content

Use Inject draft #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/ADR-008-Use-RIO-in-cardano‐cli.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Status
- [x] Adopted 2025/02/10

- [x] Adopted 2025-02-10

# Required Reading

Expand Down Expand Up @@ -183,4 +182,4 @@ The purpose of `CustomCliException` is to represent explicitly thrown, structure
# Consequences
- This should dramatically improve our code's composability and remove many unnecessary error types.
- Readability concerning what errors can be thrown will be negatively impacted. However, `ExceptT` already lies about what exceptions can be thrown because it is not limited to the error type stated in `ExceptT`'s type signature. In other words, `IO` can implicitly throw other `Exception`s.
- Initially, this will be adopted under the "compatible" group of commands so `cardano-cli` will have a design split temporarily. Once we are happy with the result we will propagate to the rest of `cardano-cli`
- Initially, this will be adopted under the "compatible" group of commands so `cardano-cli` will have a design split temporarily. Once we are happy with the result we will propagate to the rest of `cardano-cli`
2 changes: 1 addition & 1 deletion docs/ADR-009-cardano-api-exports-convention.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Status

✅ Accepted 21-02-2025
✅ Accepted 2025-02-21

# Context

Expand Down
2 changes: 1 addition & 1 deletion docs/ADR-010-cardano-api-script-witness-api.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Status

-[x] Accepted 13-03-2025
-[x] Accepted 2025-03-13

# Context

Expand Down
13 changes: 13 additions & 0 deletions docs/ADR-014-Use-Inject-internally-for-total-conversions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Status

- [ ] Proposed 2024-05-07

# Context

Use `Inject` & `Convert` for internal conversion functions.

Use dedicated functions with explicit name for exported conversion functions.

# Decision

# Consequences