fix(ogmios): ignore byron signatures in ogmios mapper

mkazlauskas · mkazlauskas · commit 14958118a981 · 2024-08-12T16:48:46.000+03:00
we are not currently using signatures

our signatures key validation only supports praos txes
diff --git a/packages/ogmios/src/ogmiosToCore/tx.ts b/packages/ogmios/src/ogmiosToCore/tx.ts
@@ -450,7 +450,8 @@ const mapCommonTx = (tx: Schema.Transaction): Cardano.OnChainTx => {
       // ...(tx.scripts && { scripts: [...Object.values(tx.scripts).map(mapScript)] }),
       signatures: new Map(
         tx.signatories
-          .filter((signatory) => !signatory.addressAttributes && !signatory.chainCode)
+          // omitting Byron signatures (length is 128 instead of 64 as in praos transactions)
+          .filter((signatory) => !signatory.addressAttributes && !signatory.chainCode && signatory.key.length === 64)
           .map(({ key, signature }) => [Crypto.Ed25519PublicKeyHex(key), Crypto.Ed25519SignatureHex(signature)])
       )
     }

Original file line number	Diff line number	Diff line change
`@@ -450,7 +450,8 @@ const mapCommonTx = (tx: Schema.Transaction): Cardano.OnChainTx => {`
`450`	`450`	`// ...(tx.scripts && { scripts: [...Object.values(tx.scripts).map(mapScript)] }),`
`451`	`451`	`signatures: new Map(`
`452`	`452`	`tx.signatories`
`453`		`- .filter((signatory) => !signatory.addressAttributes && !signatory.chainCode)`
	`453`	`+ // omitting Byron signatures (length is 128 instead of 64 as in praos transactions)`
	`454`	`+ .filter((signatory) => !signatory.addressAttributes && !signatory.chainCode && signatory.key.length === 64)`
`454`	`455`	`.map(({ key, signature }) => [Crypto.Ed25519PublicKeyHex(key), Crypto.Ed25519SignatureHex(signature)])`
`455`	`456`	`)`
`456`	`457`	`}`