Genesis now parsed by parameters-state module #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
shd
commented
Jun 17, 2025
shd
commented
- Genesis parsing moved from bootstrapper to parameters-state
- Added byron and shelley genesis parameter sets
sandtreader
reviewed
Jun 18, 2025
sandtreader
reviewed
Jun 18, 2025
| let message_enum = Message::Cardano(( | ||
| block_info, | ||
| CardanoMessage::GenesisComplete(completion_message), | ||
| CardanoMessage::GenesisComplete(GenesisCompleteMessage { | ||
| conway_genesis: None |
There was a problem hiding this comment.
We can remove this flag entirely now, I think?
There was a problem hiding this comment.
I do not use "GenesisComplete" anymore, so maybe it could be done
sandtreader
reviewed
Jun 18, 2025
| @@ -23,8 +18,6 @@ const DEFAULT_COMPLETION_TOPIC: &str = "cardano.sequence.bootstrapped"; | |||
|
|
|||
| // Include genesis data (downloaded by build.rs) | |||
| const MAINNET_BYRON_GENESIS: &[u8] = include_bytes!("../downloads/mainnet-byron-genesis.json"); | |||
| const MAINNET_SHELLEY_GENESIS: &[u8] = include_bytes!("../downloads/mainnet-shelley-genesis.json"); | |||
There was a problem hiding this comment.
These need removing from its build.rs too
sandtreader
reviewed
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.