refactor: make token a watch channel

[prestwich]

No description provided.

[prestwich]

• refactor: make token a watch channel #39 👈 (View in Graphite)
• feat(perms): tx-cache client wrapper that has a SharedToken #38
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Evalir]

The actual plus for this fn is that this:

• does not produce a potentially blocking borrow for the sender half no? (as the secret is inspected and the ownership is transferred, this is safe to hold for a longer amount of time)
• does not mark the actual token value as seen for all subsequent copies of the channel until the token is refreshed, as the receiver is cloned

no?

[prestwich]

does not mark the actual token value as seen for all subsequent copies of the channel until the token is refreshed, as the receiver is cloned

this is not really relevant, as we don't have any situations where we wait for the next updated token. We always care only about the immediate value. If we hypothetically wanted to take some action on token refresh, we would care about updating

[prestwich]

I see the actual + for this function compared to the previous version with the rwlock that you can .await it before auth has been completed

[prestwich]

the other thing here is not requiring &mut. documenting that it won't update the channel is more about letting people know a side effect of using &self. We don't want consumers to need &mut

[prestwich]

please don't add merge commits they make it harder to resolve issues when things go wrong

[Evalir]

lgtm