Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Parameter binding for client's query() method #678

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Parameter binding for client's query() method #678

merged 4 commits into from
Mar 20, 2019

Conversation

clslgrnc
Copy link
Contributor

@clslgrnc clslgrnc commented Feb 7, 2019

Closes #603, closes #316. Enables the following:

client.query('select Int_value from cpu_load_short where host=$host_var;',
             bind_params={'host_var': 'server01'})

The last commit ensures all tests pass and is unrelated to the rest of this PR (feel free to revert it, #671 is probably a better suggestion).

@clslgrnc
Copy link
Contributor Author

clslgrnc commented Feb 7, 2019

Obviously, travis fails without #674 #679 and is unable to check this PR properly.

@clslgrnc
Copy link
Contributor Author

Used @fl4p more elegant fix: bcac807

@clslgrnc
Copy link
Contributor Author

Rebasing to #679, hoping it will eventually get merged.

@clslgrnc
Copy link
Contributor Author

rebased to master (let me know when rebases stop being acceptable) to remove #679 now that travis is fixed

@xginn8
Copy link
Collaborator

xginn8 commented Mar 14, 2019

@clslgrnc can you add a changelog entry please?

@clslgrnc
Copy link
Contributor Author

Done.

@xginn8 xginn8 merged commit afcfd25 into influxdata:master Mar 20, 2019
@xginn8
Copy link
Collaborator

xginn8 commented Mar 20, 2019

lgtm, thank you @clslgrnc!

LloydW93 pushed a commit to bbc/influxdb-python that referenced this pull request Apr 15, 2019
* add bind_params to query
* tutorial for bind_params
tux-00 pushed a commit to tux-00/influxdb-python that referenced this pull request Apr 24, 2019
* add bind_params to query
* tutorial for bind_params
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client's query() method should directly support parameter binding [feature][security] Add an option to escape queries
2 participants