Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

add consistency parameter to write_points #664

Merged
merged 5 commits into from
Apr 8, 2019

Conversation

RonRothman
Copy link
Contributor

This PR adds a consistency parameter to InfluxDBClient.write_points.

Motivated by this issue: #643.

@aviau
Copy link
Collaborator

aviau commented Dec 14, 2018

Great! I'd merge this if the tests were not broken. Someone has to fix the tests.

@RonRothman
Copy link
Contributor Author

RonRothman commented Dec 14, 2018

Thanks @aviau!

Just checking - you mean the preexisting test framework, right? Not [necessarily] the particular tests I added? (Just making sure I didn't unknowingly break something.)

@xginn8
Copy link
Collaborator

xginn8 commented Dec 14, 2018

@RonRothman some of these failures look unrelated to your change. I will try to fix those generally asap.

@RonRothman
Copy link
Contributor Author

Got it-- thanks.

@aviau
Copy link
Collaborator

aviau commented Dec 15, 2018

you mean the preexisting test framework, right?

Yes exactly! Your code looks perfectly fine.

@xginn8
Copy link
Collaborator

xginn8 commented Jan 17, 2019

@RonRothman sorry for the delay, I believe #674 should fix the issue. Once that gets merged, we'll retest this and merge if it looks good. Thanks for contributing!

@xginn8 xginn8 requested review from aviau, sebito91 and xginn8 as code owners April 1, 2019 17:49
@xginn8
Copy link
Collaborator

xginn8 commented Apr 8, 2019

@RonRothman if you are able to fix up the failing linting tests, this PR looks ready to merge. Thanks for contributing!

satisfy flake8
satisfy pep257
@RonRothman
Copy link
Contributor Author

@xginn8 Thanks! Done.

@xginn8 xginn8 merged commit dc54e5e into influxdata:master Apr 8, 2019
LloydW93 pushed a commit to bbc/influxdb-python that referenced this pull request Apr 15, 2019
tux-00 pushed a commit to tux-00/influxdb-python that referenced this pull request Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants