Could com.influxdb:influxdb-client-test:5.0.0-SNAPSHOT drop off redundant dependencies? #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bednar
requested changes
Mar 29, 2022
|
Is this PR still relevant after #298? Regards |
I think so. |
|
@Celebrate-future, can you please rebase sources with master and fix failed checks? |
Ok，I will finish it. |
|
This PR has been closed because it has not had recent activity. Please reopen if this PR is still important to you and you want to continue with them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I found the pom file of project com.influxdb:influxdb-client-test:5.0.0-SNAPSHOT introduced 26 dependencies. However, among them, 4 libraries (15%) are not used by your project. I list the redundant dependencies below (labelled as red ones in the figure):
Redundant dependencies
org.jetbrains.kotlin:kotlin-stdlib-common:jar:1.3.70:compile
org.apiguardian:apiguardian-api:jar:1.1.0:compile
org.junit.platform:junit-platform-suite-api:jar:1.6.2:compile
org.jetbrains:annotations:jar:13.0:compile
Removing the redundant dependencies can reduce the size of project and prevent potential dependency conflict issues (i.e., multiple versions of the same library). More importantly, one of the redundant dependencies org.apiguardian:apiguardian-api:jar:1.1.0:compile induced dependency conflict in the dependency graph. As such, I suggest a refactoring operation for com.influxdb:influxdb-client-test:5.0.0-SNAPSHOT’s pom file.
The attached PR helps resolve the reported problem. It is safe to remove the unused libraries (we considered Java reflection relations when analyzing the dependencies). These changes have passed com.influxdb:influxdb-client-test:5.0.0-SNAPSHOT’s maven tests.
Best regards
Checklist
mvn testcompletes successfully