Skip to content

Add base java samples #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

stutiuneyal
Copy link
Contributor

No description provided.

@chughts chughts self-requested a review July 4, 2025 10:40
Copy link
Collaborator

@chughts chughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

800 lines of code, mostly repeated that can be condensed down to no more than 200 lines of code.

The feedback for BasicGet equally applies to the rest of the modules.

}
}

} catch (Exception e) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best to have a common method - in base class - to handle the displaying of exceptions, so can show nested exceptions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please elaborate a bit more on this?

@stutiuneyal stutiuneyal requested a review from chughts July 9, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants