Skip to content

BUG: Fix for .str.replace with repl function #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

BUG: Fix for .str.replace with repl function #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions pandas/core/strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,9 @@ def str_replace(arr, pat, repl, n=-1, case=True, flags=0):
----------
pat : string
Character sequence or regular expression
repl : string
Replacement sequence
repl : string or function
Replacement string or a function, which passed the match object and
must return a replacement string to be used. See :func:`re.sub`.
n : int, default -1 (all)
Number of replacements to make from start
case : boolean, default True
Expand All @@ -318,9 +319,9 @@ def str_replace(arr, pat, repl, n=-1, case=True, flags=0):
"""

# Check whether repl is valid (GH 13438)
if not is_string_like(repl):
raise TypeError("repl must be a string")
use_re = not case or len(pat) > 1 or flags
if not is_string_like(repl) or not callable(repl):
raise TypeError("repl must be a string or function")
use_re = not case or len(pat) > 1 or flags or callable(repl)

if use_re:
if not case:
Expand Down