Skip to content

fix: column resize inside sheet #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2020
Merged

Conversation

jake-bassett
Copy link
Contributor

@jake-bassett jake-bassett commented Nov 12, 2020

Description

Tables within a modal/sheet were using the wrong x offsets to calculate their drag offsets. Fixed by using getBoundingClientRect() to get true offsets within the viewport rather than based on the DOM hierarchy.

Testing

Manually dragged columns of tables in various locations in the product.

Checklist:

[ X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ X] Any dependent changes have been merged and published in downstream modules

@jake-bassett jake-bassett requested a review from a team as a code owner November 12, 2020 20:42
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #351 (cd1308c) into main (745637e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         729      729           
  Lines       14844    14844           
  Branches     1760     1760           
=======================================
  Hits        12806    12806           
  Misses       2007     2007           
  Partials       31       31           
Impacted Files Coverage Δ
projects/components/src/table/table.component.ts 91.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 745637e...cd1308c. Read the comment docs.

@jake-bassett jake-bassett merged commit 1767a7b into main Nov 12, 2020
@jake-bassett jake-bassett deleted the fix-column-resize-inside-sheet branch November 12, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants