refactor: updating gauge model, radius calculation and exporting handler service #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
- Coverage 86.25% 86.22% -0.03%
==========================================
Files 728 729 +1
Lines 14831 14843 +12
Branches 1760 1760
==========================================
+ Hits 12793 12799 +6
- Misses 2007 2013 +6
Partials 31 31
Continue to review full report at Codecov.
|
anandtiwary
changed the title
aaron-steinfeld
approved these changes
Nov 12, 2020
| return { | ||
| x: boundingBox.width / 2, | ||
| y: radius | ||
| y: boundingBox.height - GaugeComponent.GAUGE_AXIS_PADDING |
There was a problem hiding this comment.
We likely want this to center for tall containers, rather than always sit at the bottom of the container
There was a problem hiding this comment.
That would create alignment issues imo. By keeping it at the bottom, we can assign appropriate dimension to dash container to keep it aligned with other widgets. Noticed this while adding this gauge to an existing dash. But can sure revisit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.