feat: adding gauge widget #347
Conversation
|
|
||
|
|
||
| // Gauge | ||
| export * from './shared/components/gauge/gauge.component'; |
There was a problem hiding this comment.
Doubled up gauge component/module
| import { DonutWidgetRendererComponent } from './gauge-widget-renderer.component'; | ||
| import { DonutWidgetModel } from './gauge-widget.model'; | ||
|
|
||
| describe('Donut widget renderer component', () => { |
There was a problem hiding this comment.
Guessing this is not ready for review
Codecov Report
@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 86.23% 86.25% +0.02%
==========================================
Files 725 728 +3
Lines 14807 14831 +24
Branches 1760 1896 +136
==========================================
+ Hits 12769 12793 +24
+ Misses 2007 2005 -2
- Partials 31 33 +2
Continue to review full report at Codecov.
|
| const modelFactory = createModelFactory(); | ||
|
|
||
| const data: GaugeWidgetData = { | ||
| value: 5, |
There was a problem hiding this comment.
Hmm - I think I'd expect the max and thresholds to come from the widget model rather than the data model - those seem like they're independent of where we actually get the value from, and would allow dropping in our existing aggregation data sources.
Description
Please include a summary of the change, motivation and context.
Adding Gauge Dashboard widget
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Added unit tests for both widget and its model. Also did some manual test. We need to ensure the widget renders the data correctly.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.