fix: fix css for medium modal dimensions #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #346 +/- ##
========================================
Coverage 86.23% 86.23%
========================================
Files 725 725
Lines 14807 14807
Branches 1896 1760 -136
========================================
Hits 12769 12769
- Misses 2005 2007 +2
+ Partials 33 31 -2
Continue to review full report at Codecov.
|
| @@ -17,8 +17,8 @@ | |||
| } | |||
|
|
|||
| &.modal-size-medium { | |||
| height: 456px; | |||
| width: 530px; | |||
| height: 530px; | |||
There was a problem hiding this comment.
@jake-bassett you added this size for your use case right? did you need it in the other orientation?
There was a problem hiding this comment.
This size works for what I'm doing too.
jake-bassett
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing CSS for medium size modal