Skip to content

fix: update layout trigger to emit on first layout #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

aaron-steinfeld
Copy link
Contributor

Description

This change to layout triggering means a layout will be triggered on an initial render, in addition to the existing behavior of trigger on a render change. This is important as many visualizations depend on measuring their container to layout, which can't be accurately done until the parent has layed out.

Testing

Manually verified that the layout sequence produces an accurate measurement. This isn't feasible to automate, as our tests don't run with a layed out dom.

Checklist:

  • My changes generate no new warnings
  • [n/a] I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@aaron-steinfeld aaron-steinfeld requested a review from a team as a code owner November 9, 2020 20:20
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #345 (cd5fd1f) into main (2f413bd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   86.20%   86.20%   -0.01%     
==========================================
  Files         721      721              
  Lines       14684    14683       -1     
  Branches     1745     1876     +131     
==========================================
- Hits        12659    12658       -1     
+ Misses       1995     1993       -2     
- Partials       30       32       +2     
Impacted Files Coverage Δ
...ents/src/layout/layout-change-trigger.directive.ts 100.00% <100.00%> (ø)
...pover/position-strategy/mouse-position-strategy.ts 9.67% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f413bd...cd5fd1f. Read the comment docs.

@aaron-steinfeld aaron-steinfeld merged commit 3828a01 into main Nov 9, 2020
@aaron-steinfeld aaron-steinfeld deleted the fix-layout branch November 9, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants