refactor: adding borders to timeline card #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
previously approved these changes
Nov 6, 2020
| @@ -167,6 +167,6 @@ describe('Timeline Card List component', () => { | |||
| }); | |||
|
|
|||
| expect(spectator.query('.time')).not.toExist(); | |||
| expect(spectator.query('.button')).not.toBe(spectator.query('.with-margin')); | |||
| expect(spectator.query('.button')).toBe(spectator.query('.with-margin')); | |||
There was a problem hiding this comment.
this is likely not a useful thing to verify any more since it's just a static class.
There was a problem hiding this comment.
We do want to ensure margin is applied. But yeah, we dont test that usually
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 86.20% 86.20%
=======================================
Files 721 721
Lines 14684 14684
Branches 1877 1877
=======================================
Hits 12659 12659
+ Misses 1995 1993 -2
- Partials 30 32 +2
Continue to review full report at Codecov.
|
aaron-steinfeld
previously approved these changes
Nov 6, 2020
aaron-steinfeld
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor: adding borders to timeline card
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.