Skip to content

Commit d435175

Browse files
Copilotdblnz
andcommitted
Revert guest crate changes except guest_logger.rs
Co-authored-by: dblnz <[email protected]>
1 parent d020eab commit d435175

File tree

11 files changed

+26
-39
lines changed

11 files changed

+26
-39
lines changed

Cargo.lock

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/hyperlight_guest_bin/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,10 @@ hyperlight-guest = { workspace = true, default-features = false }
2525
hyperlight-common = { workspace = true, default-features = false }
2626
hyperlight-guest-tracing = { workspace = true, default-features = false }
2727
buddy_system_allocator = "0.11.0"
28+
log = { version = "0.4", default-features = false }
2829
spin = "0.10.0"
2930
flatbuffers = { version = "25.2.10", default-features = false }
30-
tracing = { version = "0.1.41", default-features = false, features = ["attributes", "log"] }
31+
tracing = { version = "0.1.41", default-features = false, features = ["attributes"] }
3132

3233
[lints]
3334
workspace = true

src/hyperlight_guest_bin/src/guest_function/call.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ fn internal_dispatch_function() {
9090
let handle = unsafe { GUEST_HANDLE };
9191

9292
#[cfg(debug_assertions)]
93-
tracing::trace!("internal_dispatch_function");
93+
log::trace!("internal_dispatch_function");
9494

9595
let function_call = handle
9696
.try_pop_shared_input_data_into::<FunctionCall>()

src/hyperlight_guest_bin/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ use hyperlight_common::mem::HyperlightPEB;
3232
use hyperlight_common::outb::OutBAction;
3333
use hyperlight_guest::exit::{halt, write_abort};
3434
use hyperlight_guest::guest_handle::handle::GuestHandle;
35+
use log::LevelFilter;
3536
use spin::Once;
36-
use tracing::log::LevelFilter;
3737

3838
// === Modules ===
3939
#[cfg(target_arch = "x86_64")]

src/hyperlight_guest_capi/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ hyperlight-guest-bin = { workspace = true, default-features = true }
1717
hyperlight-common = { workspace = true, default-features = false }
1818

1919
flatbuffers = { version = "25.2.10", default-features = false }
20-
tracing = { version = "0.1.41", default-features = false, features = ["log"] }
20+
log = { version = "0.4", default-features = false }
2121

2222
[build-dependencies]
2323
cbindgen = "0.29.2"

src/hyperlight_guest_capi/src/logging.rs

Lines changed: 11 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -16,41 +16,21 @@ limitations under the License.
1616

1717
use core::ffi::c_char;
1818

19-
/// C-compatible log level enum
20-
#[repr(C)]
21-
#[derive(Debug, Copy, Clone, PartialEq, Eq)]
22-
pub enum Level {
23-
Error = 1,
24-
Warn = 2,
25-
Info = 3,
26-
Debug = 4,
27-
Trace = 5,
28-
}
29-
30-
impl From<Level> for tracing::log::Level {
31-
fn from(level: Level) -> Self {
32-
match level {
33-
Level::Error => tracing::log::Level::Error,
34-
Level::Warn => tracing::log::Level::Warn,
35-
Level::Info => tracing::log::Level::Info,
36-
Level::Debug => tracing::log::Level::Debug,
37-
Level::Trace => tracing::log::Level::Trace,
38-
}
39-
}
40-
}
41-
4219
#[unsafe(no_mangle)]
43-
pub extern "C" fn hl_log(level: Level, message: *const c_char, line: i32, file: *const c_char) {
44-
let log_level: tracing::log::Level = level.into();
45-
46-
if tracing::log::log_enabled!(log_level) {
20+
pub extern "C" fn hl_log(
21+
level: log::Level,
22+
message: *const c_char,
23+
line: i32,
24+
file: *const c_char,
25+
) {
26+
if log::log_enabled!(level) {
4727
let message = unsafe { core::ffi::CStr::from_ptr(message).to_string_lossy() };
4828
let file = unsafe { core::ffi::CStr::from_ptr(file).to_string_lossy() };
4929

50-
tracing::log::logger().log(
51-
&tracing::log::RecordBuilder::new()
52-
.args(format_args!("{}: {}", log_level, message))
53-
.level(log_level)
30+
log::logger().log(
31+
&log::RecordBuilder::new()
32+
.args(format_args!("{}: {}", level, message))
33+
.level(level)
5434
.line(Some(line as u32))
5535
.file(Some(&file))
5636
.build(),

src/tests/rust_guests/dummyguest/Cargo.lock

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/tests/rust_guests/simpleguest/Cargo.lock

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/tests/rust_guests/simpleguest/Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ hyperlight-guest = { path = "../../../hyperlight_guest" }
88
hyperlight-guest-bin = { path = "../../../hyperlight_guest_bin" }
99
hyperlight-common = { path = "../../../hyperlight_common", default-features = false }
1010
hyperlight-guest-tracing = { path = "../../../hyperlight_guest_tracing" }
11-
tracing = { version = "0.1.41", default-features = false, features = ["attributes", "log"] }
11+
log = {version = "0.4", default-features = false }
12+
tracing = { version = "0.1.41", default-features = false, features = ["attributes"] }
1213

1314
[features]
1415
default = []

src/tests/rust_guests/simpleguest/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ use hyperlight_guest_bin::host_comm::{
5252
};
5353
use hyperlight_guest_bin::memory::malloc;
5454
use hyperlight_guest_bin::{MIN_STACK_ADDRESS, guest_logger};
55-
use tracing::log::{LevelFilter, error};
55+
use log::{LevelFilter, error};
5656
use tracing::{Span, instrument};
5757

5858
extern crate hyperlight_guest;
@@ -687,7 +687,7 @@ fn log_message(function_call: &FunctionCall) -> Result<Vec<u8>> {
687687
let level = LevelFilter::iter().nth(level as usize).unwrap().to_level();
688688

689689
match level {
690-
Some(level) => tracing::log::log!(level, "{}", &message),
690+
Some(level) => log::log!(level, "{}", &message),
691691
None => {
692692
// was passed LevelFilter::Off, do nothing
693693
}

0 commit comments

Comments
 (0)