Remove unused dev-dependency on pnet_datalink
#3093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed since #2929 landed (and then #2949 really burned the forest) - this change saves 4 crates from the build.
The other (non-
dev) crates reported bycargo udepsare harder to eliminate:httpdateused byserver AND (http1 OR http2)wantused byclient AND (http1 OR http2)tracingused byhttp1 OR http2Requirements of the form
A AND (B OR C)are unrepresentable perfectly inCargo.tomleven with the new features syntax but we might be able to do something sensible here. If it's a reasonable assumption that(http1 OR http2)is logically always true (since hyper is pretty nerfed without at least one of these) then we could makeserverdepend onhttpdateandclientonwant(andtracingdrops out automatically). Making these changes saves 2 crates for non-client builds and 1 from non-server builds.