Rust update: Remove proc and implementation of AnyRefExt for static NetworkStream #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… require 'static lifetime
|
sweet thanks! |
seanmonstar
added a commit
that referenced
this pull request
Dec 16, 2014
Rust update: Remove proc and implementation of AnyRefExt for static NetworkStream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proc()has been replaced withmove ||, or sometimesmove|:|(#19338)self.get_type_id() == TypeId::of::<T>()requires a staticNetworkStream. I'm not sure about the source of this or if it's a good solution... What do you think?I'm submitting this in advance, even if the tests will fail to compile due to the
curldependency. I tried to fix that one too, but it would just give me poetry and I ran out of time for today.